AGENT SKILL

modernize

Rebase an aging pull request onto its current base and judge whether it should still land, recommending MODERNIZE, REWORK, or CLOSE. Use when asked to rebase, refresh, or modernize an old PR.

License 许可
MIT
最近更新
2026-11-14
Stars
★ 0
Forks
0

01 前言 Front Matter

name
modernize
description
Rebase an aging pull request onto its current base and judge whether it should still land, recommending MODERNIZE, REWORK, or CLOSE. Use when asked to rebase, refresh, or modernize an old PR.

02 资源文件 1

03 SKILL.md 正文

Modernize

Modernize the idea, not just the branch. A clean rebase does not prove that the PR still belongs in the product.

Guardrails

  • Always check to make sure you have pulled latest origin for your branch, main branch, and any other branch related to your work before starting.
  • Treat existing worktree changes as user-owned. Use a disposable worktree when the active worktree is dirty or is being used for other work.
  • A request to modernize or rebase a PR authorizes rebasing and updating that PR's branch. It does not authorize merging, closing, changing the base branch, or expanding scope. If the branch belongs to another contributor, confirm before rewriting it.
  • Never use an unqualified force push. Update a rebased branch with --force-with-lease against the head SHA observed before the rebase.
  • Do not post a PR comment unless the user asked for one. Use the leaving-pr-comments skill for every comment posted on the user's behalf.

Establish the PR's intent

Resolve the PR and record its URL, state, base, head repository and branch, current head SHA, author, checks, and review state. Read the title, body, linked issues, commits, review threads, and complete diff. State the smallest coherent goal the PR was trying to accomplish before judging its implementation.

Fetch the latest remote base and PR head. Use the PR's actual base branch, usually main, rather than assuming the local branch is current. Record the merge base so the original PR and subsequent base-branch changes can be compared separately.

Check what changed around it

Inspect commits and diffs added to the base branch since the PR diverged. Search merged and open PRs when titles, code paths, or behavior suggest a replacement or competing implementation.

Look beyond overlapping lines:

  • Has the same user-facing problem already been solved?
  • Did APIs, types, schemas, dependencies, or architectural boundaries change?
  • Do both sides now claim ownership of the same behavior or invariant?
  • Was the code being changed deleted, moved, or intentionally simplified?
  • Would landing the PR restore an old behavior or create two ways to do the same thing?
  • Is the original benefit still large enough to justify the maintenance cost?

Do not describe a PR as current merely because Git reports no conflicts.

Choose a disposition before pushing

Use one of these recommendations:

  • MODERNIZE: the goal is still useful and the implementation remains the right shape. Rebase, resolve conflicts, test, and update the branch.
  • REWORK: the goal is still useful, but a mechanical rebase would preserve the wrong implementation. Explain the smallest credible rewrite and stop before pushing unless the user also asked for that rework.
  • CLOSE: the PR is superseded, obsolete, directionally wrong, or no longer worth its cost. Cite concrete evidence and stop. Do not spend time rebasing an obsolete branch, and do not close it without explicit permission.

Be willing to recommend CLOSE. Age alone is not evidence, and sunk effort is not a reason to keep a PR alive.

Rebase without losing intent

For a MODERNIZE disposition:

  1. Create a safe local branch or disposable worktree at the recorded PR head.
  2. Rebase its commits onto the freshly fetched base branch.
  3. Resolve each conflict according to the PR's current intent and the base branch's newer invariants. If a conflict reveals a product or architecture disagreement, stop and reconsider the disposition instead of guessing.
  4. Compare the pre-rebase and post-rebase commit series with git range-diff and inspect the final diff. Confirm that no intentional behavior disappeared and no already-landed behavior was reintroduced.
  5. Run the repository's focused checks for the touched area. Distinguish real failures from pre-existing or infrastructure failures.
  6. Push with --force-with-lease tied to the previously observed remote head. If the lease fails, fetch and reassess rather than overwriting new work.

Do not merge the PR.

Report

Lead with MODERNIZE, REWORK, or CLOSE and the reason. Then summarize:

  • meaningful changes on the base branch;
  • conceptual conflicts or confirmation that none were found;
  • the rebase and push result, if performed;
  • checks run and their results;
  • the remaining decision or work, with a link to the PR.

Separate observed facts from judgment. Say what could not be verified instead of manufacturing confidence.

Source

Adapted from Theo Browne's tstack modernize skill. The instruction body is unchanged except for the authorization guardrail, which now scopes the update to the PR's own branch and asks before rewriting another contributor's branch. The description was rewritten to name the three outcomes. Upstream's Codex-only agents/openai.yaml was not copied, and this source note was added. The upstream MIT notice is retained in LICENSE.

04 同仓库更多 Skills

scruffydan
scruffydan/AI-Agents

writing-for-agents

Author or revise agent instruction artifacts such as AGENTS.md, skill instructions, and agent prompts. Use for their triggers, structure, constraints, and completion criteria, not ordinary coding answers or general prose editing.

★ 0
scruffydan
scruffydan/AI-Agents

why

Investigate why a design or architectural choice was made, using code history and decision records. Use for rationale questions like why X was built this way or chosen over Y, not how code works today (use teach), debugging failures, or Five Whys process analysis.

★ 0
scruffydan
scruffydan/AI-Agents

unslop

Edit prose to remove AI writing patterns such as stock vocabulary, filler, hedging, and mannered phrasing. Use when asked to unslop or de-AI text, or to polish a substantial prose draft; not for code, short routine replies, or deciding the content and structure of documentation or agent instructions.

★ 0
scruffydan
scruffydan/AI-Agents

to-tickets

Turn an established plan into independently verifiable vertical implementation slices with acceptance criteria, verification, and true dependencies. Use when breaking planned work into tickets; small changes can stay as one task.

★ 0
scruffydan
scruffydan/AI-Agents

technical-writing

Write or revise technical documentation, tutorials, how-to guides, reference material, and explanations so readers can understand and complete their task.

★ 0
scruffydan
scruffydan/AI-Agents

teach

Explain what a concept means or how code works today, from the current code and docs. Use for how-it-works questions, including why code behaves as it does, not why a design was chosen or introduced (use why) or diagnosing failures.

★ 0