AGENT SKILL

review-concurrency-state

Review Apache Pinot concurrency and state safety when locks, shared callbacks, lifecycle, or distributed metadata change.

01 前言 Front Matter

name: review-concurrency-state
domain: kb/code-review-principles.md#2-state-management--concurrency
license: Apache-2.0
triggers: [ "diff adds/removes synchronized / volatile / Atomic* / lock types", "diff touches pinot-segment-local/**/upsert/** or consumer coordinator code", "diff touches Helix state transitions, IdealState writes, or ZK node mutations", "diff modifies shared observer/callback registration paths", "diff changes check-then-act sequences on concurrent collections" ]
description: Review Apache Pinot concurrency and state safety when locks, shared callbacks, lifecycle, or distributed metadata change.

Procedure: see kb/skills/review-concurrency-state.md. Read it first, then follow it.

Run a named Pinot test class or method in its owning Maven module.

Review Apache Pinot regression coverage and test quality when behavior or tests change.

Review Apache Pinot change scope and process when assessing PR descriptions, reverts, retries, or compatibility notes.

Review Apache Pinot performance when hot paths change or a PR makes benchmark or efficiency claims.

Review Apache Pinot naming and API conventions when public names, signatures, or documentation change.

Review Apache Pinot correctness when null handling, numeric types, dispatch, or resource lifecycles change.