AGENT SKILL

review-testing

Review Apache Pinot regression coverage and test quality when behavior or tests change.

01 前言 Front Matter

name: review-testing
domain: kb/code-review-principles.md#6-testing-strategies
license: Apache-2.0
triggers: [ "diff adds or modifies any src/test/** file", "diff adds production code without a corresponding test change", "diff claims to fix a bug without a regression test", "diff touches a type-dispatch or null-aware code path" ]
description: Review Apache Pinot regression coverage and test quality when behavior or tests change.

Procedure: see kb/skills/review-testing.md. Read it first, then follow it.

Run a named Pinot test class or method in its owning Maven module.

Review Apache Pinot change scope and process when assessing PR descriptions, reverts, retries, or compatibility notes.

Review Apache Pinot performance when hot paths change or a PR makes benchmark or efficiency claims.

Review Apache Pinot naming and API conventions when public names, signatures, or documentation change.

Review Apache Pinot correctness when null handling, numeric types, dispatch, or resource lifecycles change.

Review Apache Pinot compatibility when configs, public APIs, SPI contracts, or serialized formats change.