AGENT SKILL

review-architecture

Review Apache Pinot architecture when module dependencies, SPI boundaries, abstractions, or class placement change.

01 前言 Front Matter

name: review-architecture
domain: kb/code-review-principles.md#3-code-architecture--module-design
license: Apache-2.0
triggers: [ "diff adds/moves classes across module boundaries", "diff introduces a new SPI interface or abstract class", "diff adds a new plugin directory under pinot-plugins/", "diff introduces cross-module imports (broker → server internals, etc.)", "diff touches module POM dependencies" ]
description: Review Apache Pinot architecture when module dependencies, SPI boundaries, abstractions, or class placement change.

Procedure: see kb/skills/review-architecture.md. Read it first, then follow it.

Run a named Pinot test class or method in its owning Maven module.

Review Apache Pinot regression coverage and test quality when behavior or tests change.

Review Apache Pinot change scope and process when assessing PR descriptions, reverts, retries, or compatibility notes.

Review Apache Pinot performance when hot paths change or a PR makes benchmark or efficiency claims.

Review Apache Pinot naming and API conventions when public names, signatures, or documentation change.

Review Apache Pinot correctness when null handling, numeric types, dispatch, or resource lifecycles change.