AGENT SKILL

review-change

Review a change in this repository against its invariants, specifications, tests, and documentation contract.

License 许可
Apache-2.0
所属仓库
BiscuitBin/knarr
最近更新
2026-11-15
Stars
★ 1
Forks
0

01 前言 Front Matter

name
review-change
description
Review a change in this repository against its invariants, specifications, tests, and documentation contract.

03 SKILL.md 正文

Review a change

  1. Read AGENTS.md and the specification module under docs/specs/ the change touches. Review the whole diff, not the summary of it.
  2. Check the invariants in AGENTS.md one at a time. Specs decide behaviour; effects behind sans-IO boundaries; FFI only in named *_ffi.erl modules; every process supervised; the controller writes only the annotations it owns, never replica counts, never the pod template, never a pod past deletionTimestamp.
  3. Check the change against the specification it implements. A rule, guard or threshold decided in code rather than in docs/specs/ is a finding even when the behaviour looks right.
  4. Check the test evidence. A test that only asserts a function was called is not evidence; a test that supplies observations and a clock to the decision logic and asserts the decision it produced is. An adapter without a test that proves its HTTP or Kubernetes behaviour is a finding.
  5. Check the boundaries. Nothing in the decision logic may read a clock, the network or the environment on its own, and no test may replace an injected effect with a global.
  6. Check documentation ownership. A durable fact belongs on the page that owns its topic in docs/manifest.yml, added there rather than restated.
  7. Check scope. Unrelated refactors, new dependencies, moved pins and speculative abstractions are findings in themselves.
  8. Report findings by severity with file:line, what breaks, and the smallest fix. Run just check before concluding.

04 同仓库更多 Skills

BiscuitBin
BiscuitBin/knarr

witness

Independently witness that an Allium loop's convergence claim is true and was reached honestly. Use when the user wants to verify a loop's self-report, confirm tests really pass and no generated test was weakened, produce a convergence certificate or witness record, gate CI on a trustworthy signal, or check that an autonomous run did not cheat its way to green.

★ 1
BiscuitBin
BiscuitBin/knarr

weed

Weed the Allium garden. Find where Allium specifications and implementation code have diverged, and help resolve the divergences. Use when the user wants to check spec-code alignment, compare specs against implementation, audit for spec drift or violations, sync specs with code or code with specs, or verify whether the implementation matches what the spec says.

★ 1
BiscuitBin
BiscuitBin/knarr

tend

Tend the Allium garden. Use when the user wants to write, edit, update, add to, improve, clarify, refine, restructure, fix or migrate Allium specs. Covers adding entities, rules, triggers, surfaces and contracts, fixing syntax or validation errors, renaming or refactoring within specs, migrating specs to a new language version, and translating requirements into well-formed specifications. Pushes back on vague requirements.

★ 1
BiscuitBin
BiscuitBin/knarr

spec-change

Change an Allium specification and carry the change through the tests and the implementation.

★ 1
BiscuitBin
BiscuitBin/knarr

review-docs

Add or revise a handbook page so it satisfies the documentation contract and stays reachable.

★ 1
BiscuitBin
BiscuitBin/knarr

review-change

Review a change in this repository against its invariants, specifications, tests, and documentation contract.

★ 1