[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M7DF7KVX6SH60CKCHX1F5486":3,"skill-same:01M7DF7KVX6SH60CKCHX1F5486":45},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":16,"categories":17,"keywords":18,"publishedAt":19,"linkOnly":20,"markdownContent":21,"markdownBody":22,"frontMatter":23,"refName":24,"commitSha":25,"skillDirectory":26,"forksCount":27,"repositoryHtmlUrl":28,"repositoryHomepageUrl":6,"ownerHtmlUrl":29,"ownerBlogUrl":6,"ownerDescription":6,"updatedAt":30,"install":31,"resources":44},"01M7DF7KVX6SH60CKCHX1F5486","change-review",null,"Review a completed code change for correctness, scope, architecture, tests, security, performance and evidence. Use when the user asks for a code review or a verified change reaches its review gate; use task-review for issue text and threat-modeling for a design not yet built.","andersonmrodrigues\u002Fpaved","andersonmrodrigues","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F13907380?v=4","01M7DEV3FP2VMQZ3FP2FP1TK1C","Anderson Rodrigues","01M7DEV3GC2QAQBW4FMNT98H48",1,"MIT","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Fplugins\u002Fpaved\u002Fskills\u002Fchange-review\u002FSKILL.md",[],[],"2026-11-15 14:19:17",false,"---\nname: change-review\ndescription: >-\n  Review a completed code change for correctness, scope, architecture, tests, security, performance and evidence. Use when the user asks for a code review or a verified change reaches its review gate; use task-review for issue text and threat-modeling for a design not yet built.\n---\n\n\u003C!-- Generated by Paved plugin paved@2.29.0 from core.code-review.change-review@0.7.0; edit Paved Core instead. -->\n# Change review\n\n## When to use\n\nIn the `review` phase, after verification and evidence. Also when a human asks for a\nreview of a change made by anyone.\n\n## Required context\n\nNone is required beyond the diff and its evidence record. Useful: the rules that apply\nto the changed files and the architecture context.\n\n## Preconditions\n\nVerification has run and an evidence record exists (it may be incomplete).\n\n## Procedure\n\nRead the stated intent first (the task, its claims and plan), then read the diff with\n`core.repository.diff` top to bottom and confirm with `core.repository.status` that\nnothing is left out. Review against that intent: a hunk the intent does not explain is a\nscope finding; code that does something other than the intent is a correctness finding.\n\nIn the `review` phase of a Paved workflow, the reviewer is a subagent with its own context\nthat did not write the change: the agent that implemented it starts one, gives it only the\nbrief Paved wrote (`.paved\u002Fgenerated\u002Freviews\u002F\u003Crun-id>-brief.md`), and does not review the\nchange itself. The brief names the intent, plan, evidence, diff and rules in scope, and the\ndigests the findings must carry. Paved refuses a review that was not isolated or that read\nan older plan, source or evidence.\n\nRun three passes, each reading the diff afresh. When the reviewer can start reviewers of its\nown, run each pass as one, given only the intent and the diff, on a different model\nwhen the host offers one:\n\n- **Rules pass**: the rules in scope. A rule applies to a file only when its scope\n  covers that file's path; a violation quotes the exact rule text it breaks.\n- **Diff pass**: defects visible in the changed lines alone, without outside context.\n- **Change pass**: defects in what the change introduces, reading surrounding code where\n  the diff alone cannot settle it.\n\nEach pass goes through the dimensions below and notes candidates; stop at none.\n\n1. **Scope**: every hunk is explained by the task; nothing unrelated rode along.\n2. **Correctness**: the code does what the claims say, including absent or empty\n   values, boundaries, error paths, concurrency and resource cleanup.\n3. **Architecture**: dependencies respect declared boundaries; responsibilities sit in\n   the layer where siblings put them.\n4. **Consistency**: naming, structure, error handling and logging match the siblings.\n5. **Maintainability**: no dead code, debug output or leftovers; no duplication a reader\n   would have to keep in sync; comments explain why, not what.\n6. **Tests**: they assert the claimed behavior, including the edge cases from step 2,\n   and would fail if the behavior broke.\n7. **Security**: if the change touches input, access control, sensitive data,\n   configuration or dependencies, run `security-review`.\n8. **Performance**: look for work inside loops that could be done once, unbounded\n   growth, and new remote calls on hot paths.\n9. **Evidence**: each supporting check actually exercises its claim. A passing suite\n   that never touches the changed code supports nothing.\n10. **Rules**: compliance entries in the evidence match the diff.\n\n**Write each finding so the owner can act on it in one read:** state what the code currently does, the concrete impact, the suggested correction, and the consequence of leaving it as-is. Keep these separate from notes and avoid generic recommendations without a traced path.\n\n**Prove** each candidate as far down this ladder as is cheap: `asserted` (said so), `cited`\n(`file:line` in the change or library source), `reasoned` (the failure walked step by step),\n`executed` (a command running the real code shows it: a test, script, build, boundary or\nrule check, or the diff for an unexplained hunk) or `reproduced` (shown in the running\nsystem). For the last two, record the command, the SHA-256 of its output and what the\nintent `expected`. Never edit the change to prove a finding.\n\n**Classify** each candidate. A *blocking* finding is a defect proven at `executed` or\n`reproduced`: code that will not build or load; wrong behavior for an input or state you\ncan name; a dependency a declared boundary forbids; an unexplained hunk; a claim its\nevidence does not exercise; a violation of an in-scope rule whose text you can quote.\nAny other surviving candidate, including a defect you could not run, is a *note* with the\nlevel it reached: recorded, never a reason to hold the change.\n\n**Discard** candidates that are:\n\n| Candidate | Why it is not a finding |\n|---|---|\n| Present before the change | Not introduced here; raise it separately if it matters |\n| Caught by a configured check | The check reports it with better precision |\n| Silenced on purpose in the code | Someone already decided; the silence is the record |\n| Dependent on an input or state you cannot name | Speculation; name the input or drop it |\n| A preference a senior reviewer would not raise | Noise that buries real findings |\n\n**Validate** every blocking finding before recording it: re-open the code and confirm\nthe defect exists as stated (the symbol is really undefined, the branch is really\nreachable, the rule's scope really covers the file), apart from the pass that found it\nwhen the agent supports that. A finding that does not survive validation is dropped.\nKeep one finding per defect, even when several passes found it, and merge findings that\nshare a root cause into one that names it.\n\nFix findings in scope, then re-run the checks the fixes affect. Record the rest. No\nfindings is a valid result: say so and list what was examined (the passes, the rules in\nscope and the claims whose evidence was confirmed).\n\n## Tools\n\n`core.repository.diff` and `core.repository.status`.\n\n## Rules\n\nAll rules in scope; `core.architecture.follow-existing-patterns` for step 4 and\n`core.quality.evidence-before-completion` for step 9.\n\n## Verification\n\nNone is required of the review itself. Recommended: `static-analysis` on the final diff.\nAny fix made during review is verified like any other change.\n\n## Evidence\n\nIn a Paved workflow, a review record at `.paved\u002Fgenerated\u002Freviews\u002F\u003Crun-id>-findings.yaml`\nin the brief's format: the reviewer, the digests it read, the passes it ran and each finding,\n`blocking` or `note`, with its `proof` and the in-scope `rule` it breaks, if any.\nBlocking findings go to the user, who decides to fix them (implementation reopens, and the\nfix is tested, verified and reviewed again) or to accept them on record. Outside a workflow,\nreport the same content in the conversation. The review supports no claim; it prepares the\nhuman review.\n\n## Completion criteria\n\n- No unexplained hunk in the diff.\n- Every claim's support was confirmed to exercise the claim.\n- Every blocking finding was validated and carries `executed` or `reproduced` proof.\n- Findings are fixed, or recorded with a reason; notes are recorded apart from them.\n\n## Failure modes\n\n| Failure | Signal | Response |\n|---|---|---|\n| Self-review | The agent that wrote the change reviews it | Start an isolated subagent with only the brief |\n| Rubber stamp | Review finds nothing in a non-trivial diff | Go through steps 2 and 9 explicitly |\n| Evidence theater | Claims backed by checks unrelated to the change | Downgrade the claim or add a real check |\n| Style over substance | Findings are all about formatting | Revisit correctness and tests first |\n| False positive | A recorded finding the code does not bear out | Validate before recording; drop what fails |\n| Unproven block | A blocking finding resting on reading or reasoning alone | Run it, or record it as a note |\n| Inherited blame | A finding points at lines the diff did not touch | Discard it, or raise it outside this review |\n| Rule by vibe | A rule finding without quoted text or out of the rule's scope | Quote the rule and check its scope, or drop it |\n\n## References\n\nNone.\n\n\n## Paved integration\n\nUse the project-local Paved contract as the source of truth. Discover state with `node \"\u003Cplugin root>\u002Fscripts\u002Fpaved.mjs\" status --json`, load only relevant `.paved\u002Fproject\u002F` context, and invoke verification with `node \"\u003Cplugin root>\u002Fscripts\u002Fpaved.mjs\" verify --json`. `\u003Cplugin root>` is the installed Paved plugin directory, two directories above this SKILL.md. Always run the launcher from the repository being worked on, never from the plugin directory. Do not edit generated integration files or bypass Paved lifecycle and ownership checks.\n","\u003C!-- Generated by Paved plugin paved@2.29.0 from core.code-review.change-review@0.7.0; edit Paved Core instead. -->\n# Change review\n\n## When to use\n\nIn the `review` phase, after verification and evidence. Also when a human asks for a\nreview of a change made by anyone.\n\n## Required context\n\nNone is required beyond the diff and its evidence record. Useful: the rules that apply\nto the changed files and the architecture context.\n\n## Preconditions\n\nVerification has run and an evidence record exists (it may be incomplete).\n\n## Procedure\n\nRead the stated intent first (the task, its claims and plan), then read the diff with\n`core.repository.diff` top to bottom and confirm with `core.repository.status` that\nnothing is left out. Review against that intent: a hunk the intent does not explain is a\nscope finding; code that does something other than the intent is a correctness finding.\n\nIn the `review` phase of a Paved workflow, the reviewer is a subagent with its own context\nthat did not write the change: the agent that implemented it starts one, gives it only the\nbrief Paved wrote (`.paved\u002Fgenerated\u002Freviews\u002F\u003Crun-id>-brief.md`), and does not review the\nchange itself. The brief names the intent, plan, evidence, diff and rules in scope, and the\ndigests the findings must carry. Paved refuses a review that was not isolated or that read\nan older plan, source or evidence.\n\nRun three passes, each reading the diff afresh. When the reviewer can start reviewers of its\nown, run each pass as one, given only the intent and the diff, on a different model\nwhen the host offers one:\n\n- **Rules pass**: the rules in scope. A rule applies to a file only when its scope\n  covers that file's path; a violation quotes the exact rule text it breaks.\n- **Diff pass**: defects visible in the changed lines alone, without outside context.\n- **Change pass**: defects in what the change introduces, reading surrounding code where\n  the diff alone cannot settle it.\n\nEach pass goes through the dimensions below and notes candidates; stop at none.\n\n1. **Scope**: every hunk is explained by the task; nothing unrelated rode along.\n2. **Correctness**: the code does what the claims say, including absent or empty\n   values, boundaries, error paths, concurrency and resource cleanup.\n3. **Architecture**: dependencies respect declared boundaries; responsibilities sit in\n   the layer where siblings put them.\n4. **Consistency**: naming, structure, error handling and logging match the siblings.\n5. **Maintainability**: no dead code, debug output or leftovers; no duplication a reader\n   would have to keep in sync; comments explain why, not what.\n6. **Tests**: they assert the claimed behavior, including the edge cases from step 2,\n   and would fail if the behavior broke.\n7. **Security**: if the change touches input, access control, sensitive data,\n   configuration or dependencies, run `security-review`.\n8. **Performance**: look for work inside loops that could be done once, unbounded\n   growth, and new remote calls on hot paths.\n9. **Evidence**: each supporting check actually exercises its claim. A passing suite\n   that never touches the changed code supports nothing.\n10. **Rules**: compliance entries in the evidence match the diff.\n\n**Write each finding so the owner can act on it in one read:** state what the code currently does, the concrete impact, the suggested correction, and the consequence of leaving it as-is. Keep these separate from notes and avoid generic recommendations without a traced path.\n\n**Prove** each candidate as far down this ladder as is cheap: `asserted` (said so), `cited`\n(`file:line` in the change or library source), `reasoned` (the failure walked step by step),\n`executed` (a command running the real code shows it: a test, script, build, boundary or\nrule check, or the diff for an unexplained hunk) or `reproduced` (shown in the running\nsystem). For the last two, record the command, the SHA-256 of its output and what the\nintent `expected`. Never edit the change to prove a finding.\n\n**Classify** each candidate. A *blocking* finding is a defect proven at `executed` or\n`reproduced`: code that will not build or load; wrong behavior for an input or state you\ncan name; a dependency a declared boundary forbids; an unexplained hunk; a claim its\nevidence does not exercise; a violation of an in-scope rule whose text you can quote.\nAny other surviving candidate, including a defect you could not run, is a *note* with the\nlevel it reached: recorded, never a reason to hold the change.\n\n**Discard** candidates that are:\n\n| Candidate | Why it is not a finding |\n|---|---|\n| Present before the change | Not introduced here; raise it separately if it matters |\n| Caught by a configured check | The check reports it with better precision |\n| Silenced on purpose in the code | Someone already decided; the silence is the record |\n| Dependent on an input or state you cannot name | Speculation; name the input or drop it |\n| A preference a senior reviewer would not raise | Noise that buries real findings |\n\n**Validate** every blocking finding before recording it: re-open the code and confirm\nthe defect exists as stated (the symbol is really undefined, the branch is really\nreachable, the rule's scope really covers the file), apart from the pass that found it\nwhen the agent supports that. A finding that does not survive validation is dropped.\nKeep one finding per defect, even when several passes found it, and merge findings that\nshare a root cause into one that names it.\n\nFix findings in scope, then re-run the checks the fixes affect. Record the rest. No\nfindings is a valid result: say so and list what was examined (the passes, the rules in\nscope and the claims whose evidence was confirmed).\n\n## Tools\n\n`core.repository.diff` and `core.repository.status`.\n\n## Rules\n\nAll rules in scope; `core.architecture.follow-existing-patterns` for step 4 and\n`core.quality.evidence-before-completion` for step 9.\n\n## Verification\n\nNone is required of the review itself. Recommended: `static-analysis` on the final diff.\nAny fix made during review is verified like any other change.\n\n## Evidence\n\nIn a Paved workflow, a review record at `.paved\u002Fgenerated\u002Freviews\u002F\u003Crun-id>-findings.yaml`\nin the brief's format: the reviewer, the digests it read, the passes it ran and each finding,\n`blocking` or `note`, with its `proof` and the in-scope `rule` it breaks, if any.\nBlocking findings go to the user, who decides to fix them (implementation reopens, and the\nfix is tested, verified and reviewed again) or to accept them on record. Outside a workflow,\nreport the same content in the conversation. The review supports no claim; it prepares the\nhuman review.\n\n## Completion criteria\n\n- No unexplained hunk in the diff.\n- Every claim's support was confirmed to exercise the claim.\n- Every blocking finding was validated and carries `executed` or `reproduced` proof.\n- Findings are fixed, or recorded with a reason; notes are recorded apart from them.\n\n## Failure modes\n\n| Failure | Signal | Response |\n|---|---|---|\n| Self-review | The agent that wrote the change reviews it | Start an isolated subagent with only the brief |\n| Rubber stamp | Review finds nothing in a non-trivial diff | Go through steps 2 and 9 explicitly |\n| Evidence theater | Claims backed by checks unrelated to the change | Downgrade the claim or add a real check |\n| Style over substance | Findings are all about formatting | Revisit correctness and tests first |\n| False positive | A recorded finding the code does not bear out | Validate before recording; drop what fails |\n| Unproven block | A blocking finding resting on reading or reasoning alone | Run it, or record it as a note |\n| Inherited blame | A finding points at lines the diff did not touch | Discard it, or raise it outside this review |\n| Rule by vibe | A rule finding without quoted text or out of the rule's scope | Quote the rule and check its scope, or drop it |\n\n## References\n\nNone.\n\n\n## Paved integration\n\nUse the project-local Paved contract as the source of truth. Discover state with `node \"\u003Cplugin root>\u002Fscripts\u002Fpaved.mjs\" status --json`, load only relevant `.paved\u002Fproject\u002F` context, and invoke verification with `node \"\u003Cplugin root>\u002Fscripts\u002Fpaved.mjs\" verify --json`. `\u003Cplugin root>` is the installed Paved plugin directory, two directories above this SKILL.md. Always run the launcher from the repository being worked on, never from the plugin directory. Do not edit generated integration files or bypass Paved lifecycle and ownership checks.\n",{"name":5,"description":7},"main","1cd80f05aff924ea609012e864fa5c22c16c7d2d","plugins\u002Fpaved\u002Fskills\u002Fchange-review",0,"https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues","2026-11-14 20:09:28",{"source":8,"skillName":5,"commands":32,"prompt":42,"zipAvailable":43},[33,36,39],{"tool":34,"command":35},"npx","npx skills add andersonmrodrigues\u002Fpaved --skill change-review",{"tool":37,"command":38},"bunx","bunx skills add andersonmrodrigues\u002Fpaved --skill change-review",{"tool":40,"command":41},"pnpm","pnpm dlx skills add andersonmrodrigues\u002Fpaved --skill change-review","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Fplugins\u002Fpaved\u002Fskills\u002Fchange-review\u002FSKILL.md",true,[],[46,53,59,65,71,77],{"skillNo":47,"name":48,"nameZh":6,"description":49,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":50,"categories":51,"keywords":52,"publishedAt":19},"01M7DFBWJT4T1MPBHTWT19PBEK","sample-skill","Does a sample task. Use when a sample is needed.","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Fvalid\u002Fsample-skill\u002FSKILL.md",[],[],{"skillNo":54,"name":55,"nameZh":6,"description":49,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":56,"categories":57,"keywords":58,"publishedAt":19},"01M7DFBS6WTK30PBSW4ZS0NPWT","unexplained-contract","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Finvalid\u002Funexplained-contract\u002FSKILL.md",[],[],{"skillNo":60,"name":61,"nameZh":6,"description":49,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":62,"categories":63,"keywords":64,"publishedAt":19},"01M7DFBPJGG170V9WTMFWY73R4","shell-block","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Finvalid\u002Fshell-block\u002FSKILL.md",[],[],{"skillNo":66,"name":67,"nameZh":6,"description":49,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":68,"categories":69,"keywords":70,"publishedAt":19},"01M7DFBMZYR20JPTXNE5A8EFG6","project-identifier","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Finvalid\u002Fproject-identifier\u002FSKILL.md",[],[],{"skillNo":72,"name":73,"nameZh":6,"description":49,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":74,"categories":75,"keywords":76,"publishedAt":19},"01M7DFBJ8J533DAKA3FTF54SX3","oversized","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Finvalid\u002Foversized\u002FSKILL.md",[],[],{"skillNo":78,"name":79,"nameZh":6,"description":80,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":81,"categories":82,"keywords":83,"publishedAt":19},"01M7DFBFAD0RYCRHTZ2JW4RX7E","no-activation","Does a sample task.","https:\u002F\u002Fgithub.com\u002Fandersonmrodrigues\u002Fpaved\u002Fblob\u002Fmain\u002Ftests\u002Ffixtures\u002Fskills\u002Finvalid\u002Fno-activation\u002FSKILL.md",[],[]]