[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M7CSSTEKNQAC1X8F8EX2W21V":3,"skill-same:01M7CSSTEKNQAC1X8F8EX2W21V":48},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":16,"categories":17,"keywords":18,"publishedAt":19,"linkOnly":20,"markdownContent":21,"markdownBody":22,"frontMatter":23,"refName":25,"commitSha":26,"skillDirectory":27,"forksCount":28,"repositoryHtmlUrl":29,"repositoryHomepageUrl":30,"ownerHtmlUrl":31,"ownerBlogUrl":6,"ownerDescription":32,"updatedAt":33,"install":34,"resources":47},"01M7CSSTEKNQAC1X8F8EX2W21V","root-cause-review",null,"Use when a task in code_review was sent back before (an earlier need_revision comment exists) - verify every prior point was fixed at its root","makifbaysal\u002Ftasktrooper","makifbaysal","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F25031940?v=4","01M7CRG3ZCSYZSSEVDMW3DEYC8","Mehmet Akif Baysal","01M7CRG401FJ8YAXH5ER730XYV",122,"Apache-2.0","https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fsystem-architect\u002Fskills\u002Froot-cause-review\u002FSKILL.md",[],[],"2026-11-15 14:19:17",false,"---\nname: root-cause-review\ncategory: quality\ndescription: Use when a task in code_review was sent back before (an earlier need_revision comment exists) - verify every prior point was fixed at its root\n---\n# Root-Cause Review\n\n## Overview\n\nWhen a task returns to code_review after a need_revision cycle, the question is not \"did something change\" but \"was the ROOT CAUSE addressed\". Symptom patches come back as bugs; catching them here is cheaper than in QA or production.\n\n## The Process\n\n0. **Find the prior feedback first.** A re-submission enters code_review from `in_progress`, so the earlier need_revision comment is NOT injected into this run automatically — `list_task_comments` on this task is how you find it (also check `get_task_pull_request` for human reviewer comments on the PR itself).\n1. **Re-read the prior feedback**: your previous need_revision comment, the QA failure report, or the pipeline failure — list every numbered point.\n2. **Map each point to the new diff**: for every point, find the exact change that addresses it. A point with no matching change means the revision is incomplete → back to need_revision citing the unaddressed point.\n3. **Judge root cause vs symptom** for each fix:\n   - Symptom patch: special-casing the failing input, catching-and-ignoring the error, widening a timeout, deleting the failing assertion.\n   - Root-cause fix: the change explains WHY the failure happened and removes that mechanism at its source.\n4. **Check the guard test**: a test now exists that reproduces the original failure and passes with the fix. No guard test → Important finding.\n5. **Watch for regressions**: revision diffs are written under pressure — re-check the surrounding code paths the fix touches.\n\n## Worked Example (symptom vs root cause)\n\nPrior finding: \"export returns empty CSV on DB error (swallowed error).\"\n\n- **Resubmission A (symptom patch):** the diff wraps the export call in the handler with `if len(csv)==0 { return 500 }`. Rejected → back to need_revision: *\"Point 1: the swallowed error at service.go:24 is still there; you inferred failure from an empty result instead of propagating the error. An empty project also returns empty CSV, so this now 500s a valid empty project. Fix the source.\"*\n- **Resubmission B (root cause):** `ListByProject`'s error is propagated and mapped to 500; a test injects a repo error and asserts 500; the empty-project test still asserts 200 + header-only CSV. Approved → ready_for_qa.\n\nThe tell was step 2: B's fix touched service.go:24 (where the mechanism lives); A's didn't.\n\n## Verdict\n\n- Every prior point addressed at the root, guard tests present, pipeline green → ready_for_qa.\n- Any symptom patch, unaddressed point, or missing guard test → need_revision, quoting the specific gap (\"Point 3 from the previous review: ... — the new diff only catches the exception; the invalid state is still produced upstream in ...\").\n\n## Red Flags\n\n- The diff deletes or weakens a failing test instead of fixing the behavior.\n- A fix touches none of the files where the failure mechanism lives.\n- The fix's commit message or the revision's diff says \"fixed\" without showing what caused the failure — you never see the developer's closing message, so judge the code and the guard test, not a claim.\n- Third revision cycle on the same task — question the design: comment on whether the approach itself is wrong and consider recommending a re-analysis instead of a fourth patch. The system backs this up: three moves into need_revision without a human touch parks the task automatically, so this is also where a real disagreement belongs, not a further round-trip.\n","# Root-Cause Review\n\n## Overview\n\nWhen a task returns to code_review after a need_revision cycle, the question is not \"did something change\" but \"was the ROOT CAUSE addressed\". Symptom patches come back as bugs; catching them here is cheaper than in QA or production.\n\n## The Process\n\n0. **Find the prior feedback first.** A re-submission enters code_review from `in_progress`, so the earlier need_revision comment is NOT injected into this run automatically — `list_task_comments` on this task is how you find it (also check `get_task_pull_request` for human reviewer comments on the PR itself).\n1. **Re-read the prior feedback**: your previous need_revision comment, the QA failure report, or the pipeline failure — list every numbered point.\n2. **Map each point to the new diff**: for every point, find the exact change that addresses it. A point with no matching change means the revision is incomplete → back to need_revision citing the unaddressed point.\n3. **Judge root cause vs symptom** for each fix:\n   - Symptom patch: special-casing the failing input, catching-and-ignoring the error, widening a timeout, deleting the failing assertion.\n   - Root-cause fix: the change explains WHY the failure happened and removes that mechanism at its source.\n4. **Check the guard test**: a test now exists that reproduces the original failure and passes with the fix. No guard test → Important finding.\n5. **Watch for regressions**: revision diffs are written under pressure — re-check the surrounding code paths the fix touches.\n\n## Worked Example (symptom vs root cause)\n\nPrior finding: \"export returns empty CSV on DB error (swallowed error).\"\n\n- **Resubmission A (symptom patch):** the diff wraps the export call in the handler with `if len(csv)==0 { return 500 }`. Rejected → back to need_revision: *\"Point 1: the swallowed error at service.go:24 is still there; you inferred failure from an empty result instead of propagating the error. An empty project also returns empty CSV, so this now 500s a valid empty project. Fix the source.\"*\n- **Resubmission B (root cause):** `ListByProject`'s error is propagated and mapped to 500; a test injects a repo error and asserts 500; the empty-project test still asserts 200 + header-only CSV. Approved → ready_for_qa.\n\nThe tell was step 2: B's fix touched service.go:24 (where the mechanism lives); A's didn't.\n\n## Verdict\n\n- Every prior point addressed at the root, guard tests present, pipeline green → ready_for_qa.\n- Any symptom patch, unaddressed point, or missing guard test → need_revision, quoting the specific gap (\"Point 3 from the previous review: ... — the new diff only catches the exception; the invalid state is still produced upstream in ...\").\n\n## Red Flags\n\n- The diff deletes or weakens a failing test instead of fixing the behavior.\n- A fix touches none of the files where the failure mechanism lives.\n- The fix's commit message or the revision's diff says \"fixed\" without showing what caused the failure — you never see the developer's closing message, so judge the code and the guard test, not a claim.\n- Third revision cycle on the same task — question the design: comment on whether the approach itself is wrong and consider recommending a re-analysis instead of a fourth patch. The system backs this up: three moves into need_revision without a human touch parks the task automatically, so this is also where a real disagreement belongs, not a further round-trip.\n",{"name":5,"category":24,"description":7},"quality","main","910394a0b6db9fc8c9a8f36328ec421d3ebd8b38","catalog\u002Fagents\u002Fsystem-architect\u002Fskills\u002Froot-cause-review",18,"https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper","https:\u002F\u002Ftasktrooper.ai","https:\u002F\u002Fgithub.com\u002Fmakifbaysal","Senior Software Developer","2026-11-15 04:50:29",{"source":8,"skillName":5,"commands":35,"prompt":45,"zipAvailable":46},[36,39,42],{"tool":37,"command":38},"npx","npx skills add makifbaysal\u002Ftasktrooper --skill root-cause-review",{"tool":40,"command":41},"bunx","bunx skills add makifbaysal\u002Ftasktrooper --skill root-cause-review",{"tool":43,"command":44},"pnpm","pnpm dlx skills add makifbaysal\u002Ftasktrooper --skill root-cause-review","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fsystem-architect\u002Fskills\u002Froot-cause-review\u002FSKILL.md",true,[],[49,55,62,69,76,83],{"skillNo":50,"name":51,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":52,"categories":53,"keywords":54,"publishedAt":19},"01M7CSVEPQW6J6TD6CS2T5FPNZ","visual-craft","https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fui-designer\u002Fskills\u002Fvisual-craft\u002FSKILL.md",[],[],{"skillNo":56,"name":57,"nameZh":6,"description":58,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":59,"categories":60,"keywords":61,"publishedAt":19},"01M7CSVAQG91ETHQ0HBNZDG5FR","ux-copy","Use when you write any words a user reads in a mockup or a hand-off - content language and voice, buttons, labels, errors, empty states, confirmations, numbers and dates, and the longest-string check","https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fui-designer\u002Fskills\u002Fux-copy\u002FSKILL.md",[],[],{"skillNo":63,"name":64,"nameZh":6,"description":65,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":66,"categories":67,"keywords":68,"publishedAt":19},"01M7CSV6H0J38659NDXHJQ8396","screen-mockup-html","Use when you draw screens as the design task's HTML mockup - ONE canvas document holding every screen and every variant side by side, the sanitizer-safe recipe, phone and wide frames, the states grid, static control states, and the loopback self-check with screenshots at 375, 768 and 1440 attached to the task","https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fui-designer\u002Fskills\u002Fscreen-mockup-html\u002FSKILL.md",[],[],{"skillNo":70,"name":71,"nameZh":6,"description":72,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":73,"categories":74,"keywords":75,"publishedAt":19},"01M7CSV3JFRF3BM3XK52M7YEYR","performance-awareness","How the performance score moves for your role. Use when the score context shows a declining trend, or before handing off work you have not self-checked against every criterion.","https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fui-designer\u002Fskills\u002Fperformance-awareness\u002FSKILL.md",[],[],{"skillNo":77,"name":78,"nameZh":6,"description":79,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":80,"categories":81,"keywords":82,"publishedAt":19},"01M7CSTZDH00YRF5SCT7BRT9QD","design-variants","Use when a screen design needs variants - how many, variants as side-by-side rows on the one canvas, what makes two variants genuinely different, recommending one, how the human's choice is read, and narrowing to the chosen one in revision","https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fui-designer\u002Fskills\u002Fdesign-variants\u002FSKILL.md",[],[],{"skillNo":84,"name":85,"nameZh":6,"description":86,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":87,"categories":88,"keywords":89,"publishedAt":19},"01M7CSTV6P3SM3PAE28DB0RF77","design-system-authoring","Use when you derive, change or extend a design system - where tokens live per stack, the DTCG token tree, role-based names for both themes, base vs layer vs drift, the DESIGN.md section order, the inventory format, the contrast check and the lint every proposal returns","https:\u002F\u002Fgithub.com\u002Fmakifbaysal\u002Ftasktrooper\u002Fblob\u002Fmain\u002Fcatalog\u002Fagents\u002Fui-designer\u002Fskills\u002Fdesign-system-authoring\u002FSKILL.md",[],[]]