jvm-security-pitfalls
Use when reviewing Java or Kotlin server changes on Spring or Quarkus - security config and method security, JPA/JPQL and JdbcTemplate queries, request binding, deserialization, XML parsers, SpEL, templates, Actuator, JNDI and reflection
- License 许可
- Apache-2.0
- 最近更新
- 2026-11-15
- Stars
- ★ 122
- Forks
- 18
01 前言 Front Matter
- name
- jvm-security-pitfalls
- source
- original; informed by trailofbits/skills (CC BY-SA 4.0, ideas only, own wording); Spring Security, Spring Data and Quarkus security documentation cited, not reproduced
- category
- security
- tech_stack
- Java & Kotlin
- description
- Use when reviewing Java or Kotlin server changes on Spring or Quarkus - security config and method security, JPA/JPQL and JdbcTemplate queries, request binding, deserialization, XML parsers, SpEL, templates, Actuator, JNDI and reflection
03 SKILL.md 正文
JVM Security Pitfalls (Java, Kotlin — Spring, Quarkus)
Overview
On the JVM the dangerous code is often configuration: a matcher order, a missing @EnableMethodSecurity, a Jackson typing setting, an Actuator exposure list. Read config and annotation diffs with the same care as handler code.
1. Spring Security Configuration (CWE-285, CWE-863)
requestMatchers(...)rules are evaluated in order; a broadpermitAll()placed above a narrowerhasRole("ADMIN")wins.- A security matcher and the MVC mapping must cover the same paths — check trailing slashes, path variables and alternate mappings of the same controller.
@PreAuthorize/@Secured/@RolesAlloweddo nothing without method security enabled (@EnableMethodSecurity); a new annotated method in a module that never enables it is unprotected.csrf { disable() }/.csrf().disable()while sessions use cookies → CSRF on every state change.
// ❌ the admin rule is never reached for /api/admin/**
http.authorizeHttpRequests {
it.requestMatchers("/api/**").permitAll()
it.requestMatchers("/api/admin/**").hasRole("ADMIN")
}
// ✅ most specific first, deny by default
http.authorizeHttpRequests {
it.requestMatchers("/api/admin/**").hasRole("ADMIN")
it.requestMatchers("/api/public/**").permitAll()
it.anyRequest().authenticated()
}
Quarkus: a resource method without @RolesAllowed/@Authenticated where its siblings have one; @PermitAll added; quarkus.http.auth.permission.<name>.policy=permit widened to a broader paths=; quarkus.security.jaxrs.deny-unannotated-endpoints turned off.
2. Queries (CWE-89)
// ❌ JPQL injection
em.createQuery("SELECT u FROM User u WHERE u.email = '" + email + "'", User.class);
// ✅
em.createQuery("SELECT u FROM User u WHERE u.email = :email", User.class).setParameter("email", email);
Also: createNativeQuery with concatenation; JdbcTemplate.query("… " + x); @Query built with string concatenation in a custom repository; Spring Data JpaSort.unsafe(userInput) (plain Sort.by validates property names — unsafe does not); Panache find("name = '" + n + "'") instead of find("name", n) or find("name = ?1", n).
3. Request Binding (CWE-915)
// ❌ the JPA entity is the request body: role, ownerId, verified are all client-settable
@PostMapping("/users/{id}") User update(@PathVariable UUID id, @RequestBody User body) { … }
// ✅ a request record with only the editable fields
record UpdateProfile(String displayName, String bio) {}
@ModelAttribute on an entity binds every setter unless @InitBinder restricts setAllowedFields. Returning the entity serialises fields like passwordHash.
4. Deserialization and Reflection (CWE-502, CWE-470)
ObjectInputStream.readObjecton network, cache, cookie or file input without anObjectInputFilterallowlist.- Jackson
activateDefaultTyping(...)/enableDefaultTyping(), or@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS)on a type bound from requests — the client picks the class. XMLDecoder, XStream without a type allowlist, SnakeYAML < 2.0new Yaml().load(...), Kryo without registration required, Hessian/Burlap endpoints.Class.forName(userValue)+ instantiation;InitialContext.lookup(userValue)(JNDI → remote class loading) — CRITICAL when reachable.
5. XML Parsers (CWE-611)
// ❌ DTDs and external entities resolved
DocumentBuilder db = DocumentBuilderFactory.newInstance().newDocumentBuilder();
// ✅
DocumentBuilderFactory f = DocumentBuilderFactory.newInstance();
f.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
f.setXIncludeAware(false);
f.setExpandEntityReferences(false);
The same applies to SAXParserFactory, XMLInputFactory (SUPPORT_DTD false), TransformerFactory, SchemaFactory, Unmarshaller built on an unconfigured source.
6. Expression and Template Injection (CWE-917, CWE-1336)
// ❌ SpEL from input with a full evaluation context → T(java.lang.Runtime).getRuntime().exec(…)
parser.parseExpression(userFilter).getValue(new StandardEvaluationContext(root));
// ✅ no user-authored expressions; if unavoidable, SimpleEvaluationContext (no type references)
parser.parseExpression(userFilter).getValue(SimpleEvaluationContext.forReadOnlyDataBinding().build(), root);
Thymeleaf: a controller returning a view name built from input ("pages/" + page) enables expression preprocessing (__${…}__); th:utext with user content is XSS. FreeMarker templates authored by users with ?new / ?api available.
7. Operational Exposure
- Actuator:
management.endpoints.web.exposure.include=*(or addingenv,heapdump,threaddump,jolokia,loggers) on a port reachable without authentication → secrets inenv/heap dumps, HIGH. server.error.include-stacktrace=always/include-message=alwaysin production profiles → information exposure (note unless it leaks secrets).- H2 console or Swagger UI enabled in a production profile with no auth.
8. Commands, Paths, Randomness, Tokens
Runtime.exec(String)tokenises without a shell;ProcessBuilder("sh", "-c", cmd)andarrayOf("bash", "-c", …)reintroduce it.Paths.get(base, name).normalize().startsWith(base)ignores symlinks — comparetoRealPath()(path-traversal-and-file-handling).java.util.Random/kotlin.random.Random/Math.random()for tokens →SecureRandom.- JWT:
JWT.decode(token)(java-jwt) does not verify; jjwtparser().unsecured()or accepting unsecured JWS; algorithm not pinned. - Trust-all
X509TrustManager,HostnameVerifier { _, _ -> true },NoopHostnameVerifier.
Common Mistakes
- Reporting Criteria API,
setParameteror derived Spring Data queries as SQL injection. - Reporting
Runtime.exec(String)as shell injection. - Reporting Jackson without default typing as unsafe deserialization — plain Jackson binding to concrete types is fine.
- Missing that a method annotation is inert because method security is off.
Red Flags
permitAll()or@PermitAllin a diff;csrfdisabled in a cookie-session app.+insidecreateQuery,createNativeQuery,JdbcTemplate, Panachefind(.readObject(,activateDefaultTyping,Id.CLASS,XMLDecoder,InitialContext.lookup.parseExpression(on anything from a request.exposure.include=*outside a dev profile.
References (names and links only)
Spring Security reference · Quarkus security · CWE-89, 285, 470, 502, 611, 863, 915, 917, 1336 · OWASP Top 10:2025
04 同仓库更多 Skills
visual-craft
暂无简介
ux-copy
Use when you write any words a user reads in a mockup or a hand-off - content language and voice, buttons, labels, errors, empty states, confirmations, numbers and dates, and the longest-string check
screen-mockup-html
Use when you draw screens as the design task's HTML mockup - ONE canvas document holding every screen and every variant side by side, the sanitizer-safe recipe, phone and wide frames, the states grid, static control states, and the loopback self-check with screenshots at 375, 768 and 1440 attached to the task
performance-awareness
How the performance score moves for your role. Use when the score context shows a declining trend, or before handing off work you have not self-checked against every criterion.
design-variants
Use when a screen design needs variants - how many, variants as side-by-side rows on the one canvas, what makes two variants genuinely different, recommending one, how the human's choice is read, and narrowing to the chosen one in revision
design-system-authoring
Use when you derive, change or extend a design system - where tokens live per stack, the DTCG token tree, role-based names for both themes, base vs layer vs drift, the DESIGN.md section order, the inventory format, the contrast check and the lint every proposal returns