[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M7BJ42G6N12AM0FQMJS59HDK":3,"skill-same:01M7BJ42G6N12AM0FQMJS59HDK":52},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":16,"categories":17,"keywords":18,"publishedAt":19,"linkOnly":20,"markdownContent":21,"markdownBody":22,"frontMatter":23,"refName":24,"commitSha":25,"skillDirectory":26,"forksCount":14,"repositoryHtmlUrl":27,"repositoryHomepageUrl":6,"ownerHtmlUrl":28,"ownerBlogUrl":29,"ownerDescription":30,"updatedAt":31,"install":32,"resources":45},"01M7BJ42G6N12AM0FQMJS59HDK","code-review",null,"Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue\u002Fspec asked for?). Delegates both reviews to isolated Pi agents in parallel and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \"review since X\".","Fatih0234\u002Fmattpocock-skills-pi","Fatih0234","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F65736358?v=4","01M7BJ3YS96S0MDYX18SFY8X63","Fatih Karahan","01M7BJ3YSX8JG44RGH5PAX0WB5",0,"MIT","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fengineering\u002Fcode-review\u002FSKILL.md",[],[],"2026-11-15 14:19:17",false,"---\nname: code-review\ndescription: \"Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue\u002Fspec asked for?). Delegates both reviews to isolated Pi agents in parallel and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \\\"review since X\\\".\"\n---\n\nTwo-axis review of the diff between `HEAD` and a fixed point the user supplies:\n\n- **Standards**: does the code conform to this repo's documented coding standards?\n- **Spec**: does the code faithfully implement the originating issue \u002F spec?\n\nBoth axes run through the Pi `subagent` tool so they have isolated model contexts, then this skill aggregates their report artifacts. In a ticket-worker, reviewers must use `worktree: false` and inherit the worker cwd, so they inspect the actual ticket changes rather than a new clean worktree. The dispatch runs in parallel, but the owning worker waits for the review fanout to finish. Keep the review `runs.all` group within the configured `parallel.concurrency` bound.\n\nThe issue tracker should have been provided to you. If `docs\u002Fagents\u002Fissue-tracker.md` is missing, tell the user to run `\u002Fskill:setup-matt-pocock-skills`.\n\n## Process\n\n### 1. Pin the fixed point\n\nWhatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.\n\nCapture the diff command once: `git diff \u003Cfixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log \u003Cfixed-point>..HEAD --oneline`.\n\nBefore going further, confirm the fixed point resolves (`git rev-parse \u003Cfixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here, before delegation.\n\n### 2. Identify the spec source\n\nLook for the originating spec, in this order:\n\n1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs\u002Fagents\u002Fissue-tracker.md`.\n2. A path the user passed as an argument.\n3. A spec file under `docs\u002F`, `specs\u002F`, or `.scratch\u002F` matching the branch name or feature.\n4. If nothing is found, ask the user where the spec is. If they say there isn't one, skip the Spec axis and report \"no spec available\".\n\n### 3. Identify the standards sources\n\nAnything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.\n\nOn top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:\n\n- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.\n- **Always a judgement call.** Each smell is a labelled heuristic (\"possible Feature Envy\"), never a hard violation. Like any standard here, skip anything tooling already enforces.\n\nEach smell reads *what it is* → *how to fix*; match it against the diff:\n\n- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.\n- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.\n- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.\n- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.\n- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.\n- **Repeated Switches**: the same `switch`\u002F`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.\n- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.\n- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.\n- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.\n- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.\n- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.\n- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.\n\n### 4. Allocate review artifacts\n\nCapture `git status --short` before delegation. Create a unique run directory at `.scratch\u002Fpi-agents\u002Fcode-review-\u003Ctimestamp>\u002F` and allocate:\n\n- `standards-review.md`\n- `spec-review.md`, when a spec exists\n\nEach reviewer may write only its assigned artifact. Reviewers expose inspection tools only; they cannot mutate project files, implementation files, Git state, or tracker state. The runtime persists their final response to the assigned output path. The ticket-worker owns any warranted fixes and the parent owns integration.\n\n### 5. Delegate both axes\n\nWhen a spec exists, invoke the Pi `subagent` tool with a `workflowScript` and `async: false`. Use `await runs.all([...])` for the two independent children:\n\n```javascript\nconst results = await runs.all([\n  { key: \"standards\", agent: \"standards-reviewer\", task: \"... Return the complete report in your final response.\", context: \"fresh\", worktree: false, output: standardsArtifact, outputMode: \"file-only\" },\n  { key: \"spec\", agent: \"spec-reviewer\", task: \"... Return the complete report in your final response.\", context: \"fresh\", worktree: false, output: specArtifact, outputMode: \"file-only\" }\n]);\nreturn results.map((result) => result.output);\n```\n\nThe Standards task includes the fixed point, full diff command, commit list, standards-source paths, the complete smell baseline from step 3, repository root, and exact Standards artifact path. The Spec task includes the fixed point, full diff command, commit list, complete spec source or exact path, repository root, and exact Spec artifact path. Set each child’s `output` to its exact artifact path and `outputMode: \"file-only\"`; because reviewers have no mutation-capable tools, the runtime persists their complete final response there. Omit `cwd` inside a ticket-worker so each child inherits that worker checkout. State in both briefs that the axes are independent and one review must not read the other's artifact. When no spec exists, use one `runs.run` child with `agent: \"standards-reviewer\"`, `context: \"fresh\"`, `worktree: false`, `output: standardsArtifact`, and `outputMode: \"file-only\"` so aggregation cannot race the report.\n\nAfter the dispatch, compare `git status --short` with the captured state. The only new paths attributable to reviewers must be their assigned artifacts. Stop and report any unexpected change before aggregation.\n\nIf the `subagent` tool is unavailable, run the two reviews as separate sequential passes, write the same artifacts, and disclose that the passes were not context-isolated.\n\n### 6. Aggregate\n\nRead the artifacts and present them under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_). If the spec was absent, put \"no spec available\" under `## Spec`.\n\nEnd with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.\n\n## Why two axes\n\nA change can pass one axis and fail the other:\n\n- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**\n- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**\n\nReporting them separately stops one axis from masking the other.\n","Two-axis review of the diff between `HEAD` and a fixed point the user supplies:\n\n- **Standards**: does the code conform to this repo's documented coding standards?\n- **Spec**: does the code faithfully implement the originating issue \u002F spec?\n\nBoth axes run through the Pi `subagent` tool so they have isolated model contexts, then this skill aggregates their report artifacts. In a ticket-worker, reviewers must use `worktree: false` and inherit the worker cwd, so they inspect the actual ticket changes rather than a new clean worktree. The dispatch runs in parallel, but the owning worker waits for the review fanout to finish. Keep the review `runs.all` group within the configured `parallel.concurrency` bound.\n\nThe issue tracker should have been provided to you. If `docs\u002Fagents\u002Fissue-tracker.md` is missing, tell the user to run `\u002Fskill:setup-matt-pocock-skills`.\n\n## Process\n\n### 1. Pin the fixed point\n\nWhatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.\n\nCapture the diff command once: `git diff \u003Cfixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log \u003Cfixed-point>..HEAD --oneline`.\n\nBefore going further, confirm the fixed point resolves (`git rev-parse \u003Cfixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here, before delegation.\n\n### 2. Identify the spec source\n\nLook for the originating spec, in this order:\n\n1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs\u002Fagents\u002Fissue-tracker.md`.\n2. A path the user passed as an argument.\n3. A spec file under `docs\u002F`, `specs\u002F`, or `.scratch\u002F` matching the branch name or feature.\n4. If nothing is found, ask the user where the spec is. If they say there isn't one, skip the Spec axis and report \"no spec available\".\n\n### 3. Identify the standards sources\n\nAnything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.\n\nOn top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:\n\n- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.\n- **Always a judgement call.** Each smell is a labelled heuristic (\"possible Feature Envy\"), never a hard violation. Like any standard here, skip anything tooling already enforces.\n\nEach smell reads *what it is* → *how to fix*; match it against the diff:\n\n- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.\n- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.\n- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.\n- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.\n- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.\n- **Repeated Switches**: the same `switch`\u002F`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.\n- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.\n- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.\n- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.\n- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.\n- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.\n- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.\n\n### 4. Allocate review artifacts\n\nCapture `git status --short` before delegation. Create a unique run directory at `.scratch\u002Fpi-agents\u002Fcode-review-\u003Ctimestamp>\u002F` and allocate:\n\n- `standards-review.md`\n- `spec-review.md`, when a spec exists\n\nEach reviewer may write only its assigned artifact. Reviewers expose inspection tools only; they cannot mutate project files, implementation files, Git state, or tracker state. The runtime persists their final response to the assigned output path. The ticket-worker owns any warranted fixes and the parent owns integration.\n\n### 5. Delegate both axes\n\nWhen a spec exists, invoke the Pi `subagent` tool with a `workflowScript` and `async: false`. Use `await runs.all([...])` for the two independent children:\n\n```javascript\nconst results = await runs.all([\n  { key: \"standards\", agent: \"standards-reviewer\", task: \"... Return the complete report in your final response.\", context: \"fresh\", worktree: false, output: standardsArtifact, outputMode: \"file-only\" },\n  { key: \"spec\", agent: \"spec-reviewer\", task: \"... Return the complete report in your final response.\", context: \"fresh\", worktree: false, output: specArtifact, outputMode: \"file-only\" }\n]);\nreturn results.map((result) => result.output);\n```\n\nThe Standards task includes the fixed point, full diff command, commit list, standards-source paths, the complete smell baseline from step 3, repository root, and exact Standards artifact path. The Spec task includes the fixed point, full diff command, commit list, complete spec source or exact path, repository root, and exact Spec artifact path. Set each child’s `output` to its exact artifact path and `outputMode: \"file-only\"`; because reviewers have no mutation-capable tools, the runtime persists their complete final response there. Omit `cwd` inside a ticket-worker so each child inherits that worker checkout. State in both briefs that the axes are independent and one review must not read the other's artifact. When no spec exists, use one `runs.run` child with `agent: \"standards-reviewer\"`, `context: \"fresh\"`, `worktree: false`, `output: standardsArtifact`, and `outputMode: \"file-only\"` so aggregation cannot race the report.\n\nAfter the dispatch, compare `git status --short` with the captured state. The only new paths attributable to reviewers must be their assigned artifacts. Stop and report any unexpected change before aggregation.\n\nIf the `subagent` tool is unavailable, run the two reviews as separate sequential passes, write the same artifacts, and disclose that the passes were not context-isolated.\n\n### 6. Aggregate\n\nRead the artifacts and present them under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_). If the spec was absent, put \"no spec available\" under `## Spec`.\n\nEnd with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.\n\n## Why two axes\n\nA change can pass one axis and fail the other:\n\n- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**\n- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**\n\nReporting them separately stops one axis from masking the other.\n",{"name":5,"description":7},"main","fc602ac9ad689ea8869fbf421373daf8b79171a3","skills\u002Fengineering\u002Fcode-review","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi","https:\u002F\u002Fgithub.com\u002FFatih0234","fatihkarahan.dev","AI Engineer curious about how things work and committed to open source. Building robust AI systems that turn research into real-world impact.","2026-08-28 07:06:23",{"source":8,"skillName":5,"commands":33,"prompt":43,"zipAvailable":44},[34,37,40],{"tool":35,"command":36},"npx","npx skills add Fatih0234\u002Fmattpocock-skills-pi --skill code-review",{"tool":38,"command":39},"bunx","bunx skills add Fatih0234\u002Fmattpocock-skills-pi --skill code-review",{"tool":41,"command":42},"pnpm","pnpm dlx skills add Fatih0234\u002Fmattpocock-skills-pi --skill code-review","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fengineering\u002Fcode-review\u002FSKILL.md",true,[46],{"path":47,"resourceType":48,"resourceTypeDesc":49,"sizeBytes":50,"sourceHtmlUrl":51},"agents\u002Fopenai.yaml","REFERENCE","参考文档",100,"https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fengineering\u002Fcode-review\u002Fagents\u002Fopenai.yaml",[53,60,67,74,81,88],{"skillNo":54,"name":55,"nameZh":6,"description":56,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":57,"categories":58,"keywords":59,"publishedAt":19},"01M7BJ6C624Q5EMTZHAFGE3XHV","writing-for-agents","Writing documents for agents. Use when creating or editing skills, or modifying AGENTS.md or CLAUDE.md.","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fproductivity\u002Fwriting-for-agents\u002FSKILL.md",[],[],{"skillNo":61,"name":62,"nameZh":6,"description":63,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":64,"categories":65,"keywords":66,"publishedAt":19},"01M7BJ6AWSJ8XXDX71QX5Z2VMF","wait-what","Stop. That last message did not land: re-pitch it.","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fproductivity\u002Fwait-what\u002FSKILL.md",[],[],{"skillNo":68,"name":69,"nameZh":6,"description":70,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":71,"categories":72,"keywords":73,"publishedAt":19},"01M7BJ693J6P8MKFH9SF1TGKJG","to-questionnaire","Turn a decision you can't fully answer into a questionnaire for someone else to fill in.","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fproductivity\u002Fto-questionnaire\u002FSKILL.md",[],[],{"skillNo":75,"name":76,"nameZh":6,"description":77,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":78,"categories":79,"keywords":80,"publishedAt":19},"01M7BJ67893HYKKE96RZ8PACDZ","teach","Teach the user a new skill or concept, within this workspace.","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fproductivity\u002Fteach\u002FSKILL.md",[],[],{"skillNo":82,"name":83,"nameZh":6,"description":84,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":85,"categories":86,"keywords":87,"publishedAt":19},"01M7BJ65QX7E8HMSXQB49K0EHA","handoff","Compact the current conversation into a handoff document for another agent to pick up.","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fproductivity\u002Fhandoff\u002FSKILL.md",[],[],{"skillNo":89,"name":90,"nameZh":6,"description":91,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":92,"categories":93,"keywords":94,"publishedAt":19},"01M7BJ640T0GPVZW330J04PH3V","grilling","Grill the user relentlessly about a plan, decision, or idea. Use when the user wants to stress-test their thinking, or uses any 'grill' trigger phrases.","https:\u002F\u002Fgithub.com\u002FFatih0234\u002Fmattpocock-skills-pi\u002Fblob\u002Fmain\u002Fskills\u002Fproductivity\u002Fgrilling\u002FSKILL.md",[],[]]