AGENT SKILL

address-pr-review

Seyal adapter for AI-SDLC review-stage remediation, adding GitHub PR, terminal architecture, repository-check, and human-ownership gates.

License 许可
Apache-2.0
所属仓库
seyal-org/seyal
最近更新
2026-11-14
Stars
★ 0
Forks
1

01 前言 Front Matter

name
address-pr-review
description
Seyal adapter for AI-SDLC review-stage remediation, adding GitHub PR, terminal architecture, repository-check, and human-ownership gates.

03 SKILL.md 正文

Address PR review

Follow the canonical generic procedure in .sdlc/framework/skills/process-review/SKILL.md. If it is unavailable, run make bootstrap-agents first.

After the approved one-batch remediation plan, use python3 scripts/seyal-ai-sdlc-claim.py begin --repo seyal-org/seyal --phase process-review --number <PR>; require verify before every state/edit/push/comment write and release after the complete handoff. The wrapper uses the same PR lock as pr-review; AI_SDLC_WORKER_ID must be unique to each live worker. No lock is held while waiting for human approval.

Use this for an existing Seyal PR whose candidate lifecycle stage is IN_REVIEW or CLOSED_UNMERGED. Reopen or rebase a closed unmerged head on that same pull request. Unfinished accepted-scope implementation remains under implement-issue. A decision blocker keeps this pull request and names the other one.

Apply only these Seyal-specific deltas:

  1. Map merge_candidate_id to the exact GitHub PR, current head SHA, owning Issue, deterministic human-owned branch, and modification authority. Read candidate_lifecycle_stage from docs/engineering/ISSUE-PROTOCOL.md: a draft PR is IMPLEMENTATION_IN_PROGRESS; a ready-for-review PR is IN_REVIEW; a closed unmerged PR that was not architecture-rejected is CLOSED_UNMERGED. Do not change the draft flag. Do not open a replacement PR.
  2. Fetch the complete unresolved review/comment set plus all required failing checks. Never fix only the newest comment.
  3. Build one remediation ledger, group duplicate symptoms by root cause, and fix the complete known in-scope blocker set on the same PR/branch. Never create a replacement implementation PR merely for remediation.
  4. Preserve Seyal architecture and hot-path invariants. A remediation that requires a new product/architecture/security authority decision stops and routes to that authority instead of being improvised in code.
  5. Re-run the narrow affected checks and then all invalidated repository/domain evidence, including make check and any applicable conformance/fuzz/performance/security/native/docs gates.
  6. Re-fetch comments, checks and exact head before handoff. Known material findings must be resolved or explicitly blocked with evidence.
  7. Confirm that the full recorded root-cause set is addressed, re-fetch exact head/reviews/CI, then hand off the same PR for a full fresh pr-review (generic rule). Review is independent, not a self-approval. If the stage is IMPLEMENTATION_IN_PROGRESS, return to implement-issue. If UNKNOWN, stop and reconcile.

Human Issue ownership remains authoritative throughout remediation. Coding agents may assist but never become Seyal work owners or independent human reviewers.

04 同仓库更多 Skills