AGENT SKILL

named-persona-adversarial-review

Code review through the lens of real engineers' documented philosophies (Torvalds, Thompson, Carmack, Kent Beck, Jobs, Cagan). Complements abstract-role adversarial review with named, sourced perspectives. Use when automated review findings feel generic, when a PR has architectural or UX impact, or when the author wants pre-submit hardening beyond standard checks.

License 许可
MIT
最近更新
2026-08-16
Stars
★ 0
Forks
0

01 前言 Front Matter

name
named-persona-adversarial-review
description
Code review through the lens of real engineers' documented philosophies (Torvalds, Thompson, Carmack, Kent Beck, Jobs, Cagan). Complements abstract-role adversarial review with named, sourced perspectives. Use when automated review findings feel generic, when a PR has architectural or UX impact, or when the author wants pre-submit hardening beyond standard checks.

02 资源文件 1

03 SKILL.md 正文

Named-Persona Adversarial Review

TL;DR: Abstract roles find abstract problems. Named engineers with documented, sourced philosophies find problems you would actually fix — as long as you cite the real principle and never invent the quote.

Triggers: "review this PR with real engineers" | "named persona review" | "philosophy-grounded review"

Example Output

CRITICAL [Torvalds]: Special-case error handling at auth.ts:47 duplicates the
  happy path. Torvalds' documented "good taste" principle: restructure so the
  special case disappears rather than adding a branch. (confidence: high — TED 2016)
WARNING  [Thompson]: parseConfig() does three unrelated things; the Unix
  "do one thing well" principle argues to split it. (confidence: high)
NOTE     [Jobs]: Error "EACCES:13" leaks an errno at the user surface; "start
  from the customer experience" argues for a human message. (confidence: high — WWDC 1997)
Verdict: CONCERNS — fix CRITICAL before merge.

Problem

Abstract adversarial review ("act as a saboteur") produces generic findings — the model imagines what a reviewer might say. This skill grounds each lens in a real, sourced engineering philosophy documented in references/persona_principles.md: what Ken Thompson actually argued about trust, what Linus actually demonstrated about good taste — not what an AI imagines.

How it differs from adversarial-reviewer: abstract roles → surface-level findings; named, sourced personas → findings anchored to a documented principle you can cite and defend.

Cost: 1 round ≈ 8-12 min. Comparable to waiting for CI.

Attribution discipline (read this first — it is the load-bearing rule)

This skill puts named, real people's principles to work. That power is also its failure mode: language models hallucinate quotes. To stay honest:

  1. Cite the principle, not a fabricated verbatim quote. Prefer paraphrasing a documented position ("Thompson's Reflections on Trusting Trust argues you can't trust code you didn't fully create") over inventing quotation marks around words the person may never have said.
  2. Attach a confidence level to every attribution — high (documented, in references/persona_principles.md with a source), moderate (widely attributed, source not pinned), low/unknown (you're inferring). Mirrors productivity/andreessen's citation discipline.
  3. If you cannot ground a persona's lens in a real source, drop that persona. A confidently-wrong quote attributed to a living engineer is worse than one fewer reviewer. Never fabricate a citation to hit the "≥1 finding" bar.
  4. The finding must stand on its own technical merit. The persona is a lens that directs attention, not the authority that makes the finding true. A real bug found "through Carmack's lens" is real because it's a bug, not because Carmack said so.

Rules

  • Ground before role-play. Anchor each persona in references/persona_principles.md (or a verifiable search) first. Ungrounded = invalid.
  • Findings stand on technical merit, with the persona's principle as the lens — see the discipline above.
  • Product persona mandatory every round. Engineers miss UX. Always include one.
  • Honesty over quantity. Don't fabricate findings or citations. Clean dimensions get reported clean (with the zero-finding burden below).
  • Zero-finding burden. "Looks fine" is only valid if you name 3+ principles the code demonstrably satisfies, and how. Non-findings are as expensive as findings.

Persona Pools

Each persona's documented principles + sources + confidence live in references/persona_principles.md.

Product (pick 1 per round — mandatory):

Persona Documented principle Best for
Steve Jobs Start from the customer experience, work back to the tech UX, onboarding
Marty Cagan Fall in love with the problem, not the solution PRDs, feature specs, scope creep
Des Traynor (Intercom) The first 30 seconds decide adoption Docs, READMEs, quick starts

Engineers (pick 2 per round):

Persona Documented principle Best for Blind spot
Ken Thompson Trust boundaries; do one thing well Architecture, supply chain, API UX, docs
Linus Torvalds Eliminate the special case ("good taste"); never break userspace Logic, data structures, compat User empathy, DX
John Carmack Measure before you optimize; performance as craft Algorithms, hot paths Minimalism
Kent Beck Simple design; make it work → right → fast Process, testability Performance, security
Fred Brooks Essential vs. accidental complexity System design, estimation Low-level perf

Routing (which personas when):

  • Code correctness → Torvalds + Carmack + Jobs
  • Architecture / design → Thompson + Brooks + Cagan
  • Documentation / API → Thompson + Beck + Traynor
  • Performance → Carmack + Torvalds + Jobs
  • Security / supply chain → Thompson + Torvalds + Cagan
  • 1st round on any PR → Torvalds + Thompson + Jobs (broadest coverage)

Severity Levels

Level Definition Action
BLOCKER 2+ personas concur on a CRITICAL, or security / data-loss risk Fix before any further work
CRITICAL Wrong result, data loss, security hole, or violated core invariant Fix before merge
WARNING Fragile, misleading, or likely to cause future bugs Fix, or explain if deferred
NOTE Improvement that doesn't affect correctness Optional; record for follow-up

Promotion: NOTE → WARNING → CRITICAL → BLOCKER. Two personas independently finding the same issue promotes it one level (concurrence is signal). BLOCKER is the ceiling.

The Process

Step 0: Read twice

  1. Top-down (comprehension): what changed, and why.
  2. Bottom-up (adversarial): read function by function, last to first. Ask what each function actually guarantees vs. what its name implies, where it can fail, and what it assumes about callers. Reading bottom-up breaks the author's mental model. Multi-file → trace one end-to-end path.

Step 1: Ground the principles first

For each persona, pull their documented principles from references/persona_principles.md (or search "[Name] engineering philosophy principles" and extract only sourced positions) before looking at the code, so you apply the principle rather than retrofitting one to an opinion you already formed.

Step 2: Review (3 independent — 2 engineers + 1 product)

Each persona gets: Mindset (one sentence from their principles), Priorities (3-5 criteria), Findings (each mapped to a documented principle + confidence level), or the zero-finding burden (3+ principles the code satisfies, with how).

Step 3: Synthesize & post

Merge duplicates; count concurrences; promote per the rule; flag single-lens findings (often the most interesting). Post the report as a PR comment (default) or save to .claude/review-[timestamp].md.

Integrity Check (Feynman)

"The first principle is that you must not fool yourself — and you are the easiest person to fool." — Richard Feynman, Cargo Cult Science (Caltech commencement, 1974)

After each round, ask:

  1. Would this person's documented philosophy actually direct attention here — or am I projecting?
  2. Did I cite a real, sourced principle (confidence marked), or dress generic advice in a famous name?
  3. Are my findings true on technical merit independent of the name attached?
  4. All NOTE-level? Then I'm narrating one perspective in different voices. Switch ≥2 personas and re-review.

Exit Condition

  • 1 round minimum for any PR.
  • BLOCKER/CRITICAL found → fix, then 1 re-review round.
  • CONCERNS (WARNING) → fix or accept risk, then 1 more round.
  • CLEAN on 2 consecutive rounds → done.
  • CLEAN on round 1 for a low-impact PR → done (1 round is enough).

When to Use

  • You want deeper coverage than standard automated checks alone.
  • A self-authored PR needs pre-submit hardening.
  • adversarial-reviewer findings feel generic and you want sourced specificity.
  • Reviewing methodologies or docs (product personas excel here).
  • Auth, data, architecture, or public-API changes.

When NOT to Use

  • Low-impact PR (cosmetic only, no logic change) → use adversarial-reviewer.
  • No web access AND the persona isn't covered in references/persona_principles.md → you can't ground it; don't fabricate.
  • Throwaway / prototype code.

Anti-Patterns

Inherits all from adversarial-reviewer. Plus:

Anti-Pattern Why wrong
Inventing a verbatim quote to sound authoritative Fabricated attribution to a real person. Cite the sourced principle + confidence, or drop it.
"As a senior engineer" without grounding Not a named, sourced lens. Ground first.
Same 3 personas every time Rotate per problem type — see Routing.
Product person skipped Product catches what engineers miss.
Fabricating a finding to hit "≥1 issue" The bar is honesty, not quota. Use the zero-finding burden instead.
Skipping the integrity check Verification without verification = rubber-stamp.
3 rounds for a trivial change Low-impact PRs: 1 round is enough.

Cross-References


Attribution: Concept contributed by @YuhaoLin2005 (PR #866). Hardened for this repo: consolidated to one location, anti-fabrication/confidence discipline added, principles sourced in references/.

04 同仓库更多 Skills

GongYuanCaiJi
GongYuanCaiJi/dsh-claude-skills

syllabus

Generates a curated supplementary reading list from any course syllabus using Consensus academic search. Grill-me intake (syllabus input format + course audience + year range) plus a grouping forcing-options checkpoint before any search runs — so the reading list matches the course's level and recency need. Parses the syllabus to extract topics and learning outcomes, searches Consensus for recent peer-reviewed papers per topic, and produces a professionally formatted .docx with clickable Consensus links, plain-language summaries calibrated to audience level, and Bloom-higher-order discussion questions tied to course learning goals. Use when the user uploads a syllabus, course outline, or curriculum document and wants supplementary readings (e.g., 'create a reading list from this syllabus', 'find recent papers for my course') — even casual mentions with a syllabus attached should trigger this skill.

★ 0
GongYuanCaiJi
GongYuanCaiJi/dsh-claude-skills

research

Default entry point for any research request — a hybrid router that classifies the question deterministically and either delegates to a specialist research skill (pulse for trends/sentiment, grants for NIH funding, litreview for academic literature, syllabus for course reading, patent for prior-art + IP landscape, dossier for entity research) or runs its own plan-decompose-multi-source-search-synthesize-cite fallback workflow when no specialist matches. Always surfaces the routing decision so users can override. Use when the user makes any research request that doesn't obviously match a more-specific specialist skill (e.g., "research [topic]", "look into [topic]", "what do we know about [topic]", "investigate [topic]", "find me information on [topic]", "do some research on [topic]", "I need to understand [topic]"). Output is a markdown briefing (default) or .docx document (on request) with full citations and an audit log.

★ 0
GongYuanCaiJi
GongYuanCaiJi/dsh-claude-skills

pulse

Multi-source recency research skill that takes the pulse of any topic across Reddit, Hacker News, the open web, and optionally X/Twitter within a configurable recent window (default 30 days). Forcing intake clarifies topic specificity, angle (trend/sentiment/problems/opportunities/comparison), time window, and platform scope before searching. Returns a synthesized briefing with citations, engagement metrics, and cross-platform pattern analysis. Use when the user requests multi-source recency intelligence on a topic (e.g., 'pulse on [topic]', 'what's happening with [topic]', 'what are people saying about [topic]', 'current conversation about [topic]', 'take the pulse of [topic]', 'trending: [topic]', 'find me info on [topic]'), and for competitor research, trend discovery, tool comparisons, and audience sentiment analysis.

★ 0
GongYuanCaiJi
GongYuanCaiJi/dsh-claude-skills

patent

Patent prior-art and landscape intelligence skill — not generic patent help. Commits to one of five sub-use-cases via forcing intake (novelty search / freedom-to-operate / competitive landscape / acquisition diligence / litigation prior-art) before any search runs. Searches Google Patents, Espacenet, USPTO, and optionally Lens.org for citation-graph signals. Output is an editable Word document (.docx) with verdict, ranked closest art (claim-text extracted), CPC-class-aware landscape, family-resolved hits, geographic coverage, FTO flags where applicable, strategy recommendations, and full audit log. Use when the user asks for patent searching or analysis (e.g., 'prior art search for [invention]', 'freedom to operate analysis for [product]'). Produces search signal, not legal advice — always recommends consulting a patent attorney before filing or licensing decisions. Trademark, copyright, and trade-secret questions are out of scope.

★ 0
GongYuanCaiJi
GongYuanCaiJi/dsh-claude-skills

notebooklm

Browser automation skill for controlling Google's NotebookLM. Use when the user wants anything done in NotebookLM (e.g., 'open NotebookLM', 'check my [name] notebook', 'ask my notebook about X', 'add [source] to NotebookLM', 'generate a Video Overview from my notebook', 'use NotebookLM Studio'). Handles reading and querying notebooks, adding sources (URLs, text, files, YouTube links, synthesized content), generating Studio outputs (Audio/Video Overviews, Mind Maps, Reports incl. Briefing Doc/Study Guide/FAQ, Flashcards, Quiz, slide decks, infographics — discover the exact set from the live Studio panel; the UI evolves fast), and creating new notebooks. Requires browser automation environment — fails gracefully when unavailable.

★ 0
GongYuanCaiJi
GongYuanCaiJi/dsh-claude-skills

litreview

Academic literature orientation skill that searches papers via free keyless APIs (PubMed E-utilities + OpenAlex) by default — with the Consensus MCP as an optional enhancement lane when connected — builds a strategic search plan using PICO (default) or SPIDER / Decomposition / hybrid as fallbacks, and synthesizes findings into a formatted Word (.docx) research guide. Grill-me intake (research question specificity + framework hint + tentative depth) before the recon search; a second forcing checkpoint after Phase 2 confirms framework + sub-areas + depth before searches consume budget. Configurable depth (5/10/20 queries) controls coverage vs. speed. Output is a 'launching pad' — an orientation guide that lets a researcher dive in confidently, not a finished review. Use when the user starts literature-oriented research (e.g., 'litreview on [topic]', 'literature review on [topic]', 'I'm starting a literature review on X', 'I'm writing a paper on X', 'help me research X', 'I'm doing research on X', 'can you help me research X'). Do NOT use for single one-off paper searches wanting a quick list — that's a plain PubMed/OpenAlex (or Consensus) query.

★ 0