AGENT SKILL
architecture-reviewer
Review architecture, module boundaries, interfaces, coupling, scalability, data flows, and technical risks.
- License 许可
- MIT
- 所属仓库
- domehahn/skil
- 最近更新
- 2026-11-11
- Stars
- ★ 1
- Forks
- 2
01 前言 Front Matter
- name
- architecture-reviewer
- since
- 2026-07-28
- authors
- [ "platform-engineering" ]
- version
- 1.0.0
- replaces
- null
- changelog
- [ { "date": "2026-07-28", "change": "Initial generated production-ready SDLC / DevSecOps skill", "version": "1.0.0" } ]
- stability
- stable
- supersedes
- []
- description
- Review architecture, module boundaries, interfaces, coupling, scalability, data flows, and technical risks.
- last_modified
- 2026-07-28
- deprecated_since
- null
- min_platform_version
- { "pi": "unknown", "bob": "unknown", "kimi": "unknown", "kiro": "unknown", "qwen": "unknown", "cline": "unknown", "codex": "unknown", "crush": "unknown", "iflow": "unknown", "junie": "unknown", "qoder": "unknown", "auggie": "unknown", "cursor": "unknown", "lingma": "unknown", "ollama": "unknown", "factory": "unknown", "amazon-q": "unknown", "continue": "unknown", "costrict": "unknown", "kilocode": "unknown", "opencode": "unknown", "roo-code": "unknown", "windsurf": "unknown", "codebuddy": "unknown", "forgecode": "unknown", "openhands": "unknown", "gemini-cli": "unknown", "gitlab-duo": "unknown", "antigravity": "unknown", "claude-code": "unknown", "github-copilot": "unknown" }
02 资源文件 9
- 资产文件assets/README.md142 B
- 参考文档CHANGELOG.md133 B
- 许可证LICENSE214 B
- 参考文档README.md376 B
- 参考文档references/README.md175 B
- 脚本scripts/README.md210 B
- 参考文档skill.yaml237 B
- 参考文档tests/README.md97 B
- 其他VERSION6 B
03 SKILL.md 正文
Architecture Reviewer
Purpose
Review architecture for module boundaries, service boundaries, coupling, cohesion, dependency direction, data ownership, resilience, security boundaries, and ADR-worthy decisions.
When to use
- A design, PR, or refactor changes architecture, module boundaries, or service boundaries.
- API contracts, shared libraries, data ownership, or deployment topology change.
- Scalability, resilience, runtime coupling, or security boundaries need review.
- Circular dependencies, layering violations, or unclear ownership are suspected.
- An ADR should be created or updated.
Operating model
- Map components, modules, services, APIs, data stores, queues, and deployment units.
- Verify dependency direction, layering, cohesion, and ownership boundaries.
- Trace data flows and ownership across tables, topics, buckets, and integrations.
- Review runtime coupling, fan-out, retry behavior, scalability, and cascading failure risk.
- Identify decisions that deserve ADRs and distinguish architecture risk from style preference.
Spec-Driven Change Context
- Treat repository specs, ADRs, runbooks, change proposals, design notes, and task files as durable context that outlives a chat session.
- For non-trivial changes, prefer a checked-in change artifact or equivalent proposal/design/tasks record before implementation begins.
- Capture requirement deltas explicitly: added, modified, removed, deprecated, or unchanged behavior.
- Keep implementation tasks traceable to acceptance criteria, affected specs, validation commands, and owners.
- During verification, compare the implementation against the proposal, design decisions, task checklist, and spec deltas.
- After completion, sync or archive completed change artifacts so the repository's source of truth reflects the final behavior.
- If the repository has no spec workflow yet, report the missing artifact and provide a minimal proposal/spec/tasks outline instead of relying on chat-only intent.
Skill-Specific Review Scope
- Module boundaries, service boundaries, layering, coupling, cohesion, and circular dependencies.
- API contracts, interface stability, compatibility, and versioning.
- Data ownership, data flows, cross-boundary writes, and direct database access.
- Runtime and deployment coupling, scalability, resilience, retry storms, and fan-out.
- Security boundaries, trust boundaries, ownership, and ADR candidates.
Skill-Specific Checklist
- [ ] Identify architectural layers and verify dependency direction.
- [ ] Detect circular dependencies between modules, packages, services, or libraries.
- [ ] Check whether module boundaries align with business capabilities or clear technical responsibilities.
- [ ] Review coupling between services, APIs, databases, queues, shared libraries, and deployment units.
- [ ] Identify shared mutable state, shared database writes, hidden dependencies, and temporal coupling.
- [ ] Check public interfaces for ownership, versioning, compatibility expectations, and tests.
- [ ] Verify explicit data ownership for domain objects, tables, topics, buckets, and integrations.
- [ ] Identify cross-boundary writes or direct database access across service boundaries.
- [ ] Review synchronous call chains for fan-out, latency amplification, retry storms, and cascading failures.
- [ ] Identify ADR-worthy decisions and missing architecture documentation.
- [ ] Check security and trust boundaries between components.
- [ ] Assess deployment coupling and independent rollback ability.
Decision Rules
- If a dependency violates the intended layer direction, classify it as architecture risk.
- If circular dependencies exist, recommend interface inversion or boundary redesign.
- If data ownership is unclear, block cross-boundary writes until an owner is named.
- If synchronous fan-out can cascade failures, recommend async, timeout, circuit breaker, or fallback design.
- If a public contract lacks versioning or compatibility tests, flag interface stability risk.
- If a decision changes long-term structure, recommend an ADR.
Finding Categories
- Circular dependencies and dependency direction violations.
- Excessive coupling or weak cohesion.
- Unclear module, service, or data ownership.
- Unstable API contracts and compatibility risk.
- Runtime coupling, fan-out, retry storm, and cascading failure risk.
- Missing ADR or architecture documentation.
Severity Guidance
- Critical: architecture enables unsafe deployment, data corruption, or unavoidable cascading failure.
- High: coupling, ownership, or boundary issue blocks safe evolution or security isolation.
- Medium: maintainability, scalability, or compatibility risk is likely but controllable.
- Low: documentation or ADR gap that does not currently block delivery.
DevSecOps Guardrails
- Do not read secrets,
.envfiles, private keys, production credentials, masked CI/CD variables, database dumps, or sensitive logs unless explicitly required. - Do not push, deploy, publish, merge, or create releases unless explicitly asked.
- Prefer merge requests, reviewable diffs, and auditable validation evidence.
- Prefer least privilege, minimal changes, and explicit rollback notes.
- Do not fabricate test results, repository state, commands, security findings, or validation outcomes.
- Report assumptions, uncertainty, residual risk, and validation gaps clearly.
Output Requirements
- Architecture summary with components, boundaries, and data flows.
- Findings table with severity, component, evidence, impact, and recommendation.
- Dependency and coupling analysis with circular dependencies called out.
- API contract and data ownership review.
- Runtime resilience, scalability, and deployment coupling notes.
- ADR recommendations with decision question and rationale.
Acceptance Criteria
- Module and service boundaries are identified or marked unknown.
- Circular dependencies and layering violations are explicitly assessed.
- Data ownership and cross-boundary access are reviewed.
- Critical and High findings include concrete mitigation.
- ADR candidates are listed for broad decisions.
- Findings distinguish structural risk from style preference.
Anti-Patterns
- Reporting style preferences as architecture risk.
- Recommending service extraction without ownership and operational cost analysis.
- Ignoring data ownership while reviewing module boundaries.
- Approving circular dependencies because they compile today.
- Treating ADRs as optional for precedent-setting decisions.
- Suggesting broad rewrites for localized coupling issues.
Changelog
1.0.0 - 2026-07-28
- Initial generated production-ready SDLC / DevSecOps skill.