[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M79JR8AX0NSF7C10QJQVC4M9":3,"skill-same:01M79JR8AX0NSF7C10QJQVC4M9":51},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":9,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":15,"categories":16,"keywords":17,"publishedAt":18,"linkOnly":19,"markdownContent":20,"markdownBody":21,"frontMatter":22,"refName":23,"commitSha":24,"skillDirectory":25,"forksCount":26,"repositoryHtmlUrl":27,"repositoryHomepageUrl":28,"ownerHtmlUrl":29,"ownerBlogUrl":6,"ownerDescription":6,"updatedAt":30,"install":31,"resources":44},"01M79JR8AX0NSF7C10QJQVC4M9","code-review",null,"Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue\u002Fspec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \"review since X\".","Leehow\u002Fpipiui","Leehow","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F8022275?v=4","01M79JQKJ75AT6BQD6Q8BDZ6HX","01M79JQKK1HF42F74CMVWVS2ZJ",1,"Apache-2.0","https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fbuilt-in-skills\u002Fcode-review\u002FSKILL.md",[],[],"2026-11-15 14:19:17",false,"---\nname: code-review\ndescription: \"Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue\u002Fspec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \\\"review since X\\\".\"\n---\n\nTwo-axis review of the diff between `HEAD` and a fixed point the user supplies:\n\n- **Standards**: does the code conform to this repo's documented coding standards?\n- **Spec**: does the code faithfully implement the originating issue \u002F spec?\n\nBoth axes run as **parallel sub-agents** so they don't pollute each other's context, then this skill aggregates their findings.\n\nThe issue tracker should have been provided to you. If `docs\u002Fagents\u002Fissue-tracker.md` is missing, tell the user to run `\u002Fsetup-matt-pocock-skills`.\n\n## Process\n\n### 1. Pin the fixed point\n\nWhatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.\n\nCapture the diff command once: `git diff \u003Cfixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log \u003Cfixed-point>..HEAD --oneline`.\n\nBefore going further, confirm the fixed point resolves (`git rev-parse \u003Cfixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents.\n\n### 2. Identify the spec source\n\nLook for the originating spec, in this order:\n\n1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs\u002Fagents\u002Fissue-tracker.md`.\n2. A path the user passed as an argument.\n3. A spec file under `docs\u002F`, `specs\u002F`, or `.scratch\u002F` matching the branch name or feature.\n4. If nothing is found, ask the user where the spec is. If they say there isn't one, the **Spec** sub-agent will skip and report \"no spec available\".\n\n### 3. Identify the standards sources\n\nAnything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.\n\nOn top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:\n\n- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.\n- **Always a judgement call.** Each smell is a labelled heuristic (\"possible Feature Envy\"), never a hard violation. Like any standard here, skip anything tooling already enforces.\n\nEach smell reads *what it is* → *how to fix*; match it against the diff:\n\n- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.\n- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.\n- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.\n- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.\n- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.\n- **Repeated Switches**: the same `switch`\u002F`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.\n- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.\n- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.\n- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.\n- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.\n- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.\n- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.\n\n### 4. Spawn both sub-agents in parallel\n\n**Standards sub-agent prompt** should include:\n\n- The full diff command and commit list.\n- The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full (the sub-agent has no other access to it).\n- The brief: \"Report, per file\u002Fhunk where relevant, (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) any baseline smell you spot: name it and quote the hunk. Distinguish hard violations from judgement calls: documented-standard breaches can be hard, but baseline smells are always judgement calls, and a documented repo standard overrides the baseline. Skip anything tooling enforces. Under 400 words.\"\n\n**Spec sub-agent prompt** should include:\n\n- The diff command and commit list.\n- The path or fetched contents of the spec.\n- The brief: \"Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong. Quote the spec line for each finding. Under 400 words.\"\n\nIf the spec is missing, skip the Spec sub-agent and note this in the final report.\n\n### 5. Aggregate\n\nPresent the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_).\n\nEnd with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.\n\n## Why two axes\n\nA change can pass one axis and fail the other:\n\n- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**\n- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**\n\nReporting them separately stops one axis from masking the other.\n","Two-axis review of the diff between `HEAD` and a fixed point the user supplies:\n\n- **Standards**: does the code conform to this repo's documented coding standards?\n- **Spec**: does the code faithfully implement the originating issue \u002F spec?\n\nBoth axes run as **parallel sub-agents** so they don't pollute each other's context, then this skill aggregates their findings.\n\nThe issue tracker should have been provided to you. If `docs\u002Fagents\u002Fissue-tracker.md` is missing, tell the user to run `\u002Fsetup-matt-pocock-skills`.\n\n## Process\n\n### 1. Pin the fixed point\n\nWhatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.\n\nCapture the diff command once: `git diff \u003Cfixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log \u003Cfixed-point>..HEAD --oneline`.\n\nBefore going further, confirm the fixed point resolves (`git rev-parse \u003Cfixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents.\n\n### 2. Identify the spec source\n\nLook for the originating spec, in this order:\n\n1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs\u002Fagents\u002Fissue-tracker.md`.\n2. A path the user passed as an argument.\n3. A spec file under `docs\u002F`, `specs\u002F`, or `.scratch\u002F` matching the branch name or feature.\n4. If nothing is found, ask the user where the spec is. If they say there isn't one, the **Spec** sub-agent will skip and report \"no spec available\".\n\n### 3. Identify the standards sources\n\nAnything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.\n\nOn top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:\n\n- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.\n- **Always a judgement call.** Each smell is a labelled heuristic (\"possible Feature Envy\"), never a hard violation. Like any standard here, skip anything tooling already enforces.\n\nEach smell reads *what it is* → *how to fix*; match it against the diff:\n\n- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.\n- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.\n- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.\n- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.\n- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.\n- **Repeated Switches**: the same `switch`\u002F`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.\n- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.\n- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.\n- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.\n- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.\n- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.\n- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.\n\n### 4. Spawn both sub-agents in parallel\n\n**Standards sub-agent prompt** should include:\n\n- The full diff command and commit list.\n- The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full (the sub-agent has no other access to it).\n- The brief: \"Report, per file\u002Fhunk where relevant, (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) any baseline smell you spot: name it and quote the hunk. Distinguish hard violations from judgement calls: documented-standard breaches can be hard, but baseline smells are always judgement calls, and a documented repo standard overrides the baseline. Skip anything tooling enforces. Under 400 words.\"\n\n**Spec sub-agent prompt** should include:\n\n- The diff command and commit list.\n- The path or fetched contents of the spec.\n- The brief: \"Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong. Quote the spec line for each finding. Under 400 words.\"\n\nIf the spec is missing, skip the Spec sub-agent and note this in the final report.\n\n### 5. Aggregate\n\nPresent the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_).\n\nEnd with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.\n\n## Why two axes\n\nA change can pass one axis and fail the other:\n\n- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**\n- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**\n\nReporting them separately stops one axis from masking the other.\n",{"name":5,"description":7},"main","0fc8c5f1d479ff1d7a0f392920d9479a67d4d884","Electron\u002Fresources\u002Fruntime\u002Fbuilt-in-skills\u002Fcode-review",0,"https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui","https:\u002F\u002Fpipi.aichattrpg.com\u002F","https:\u002F\u002Fgithub.com\u002FLeehow","2026-10-22 22:52:03",{"source":8,"skillName":5,"commands":32,"prompt":42,"zipAvailable":43},[33,36,39],{"tool":34,"command":35},"npx","npx skills add Leehow\u002Fpipiui --skill code-review",{"tool":37,"command":38},"bunx","bunx skills add Leehow\u002Fpipiui --skill code-review",{"tool":40,"command":41},"pnpm","pnpm dlx skills add Leehow\u002Fpipiui --skill code-review","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fbuilt-in-skills\u002Fcode-review\u002FSKILL.md",true,[45],{"path":46,"resourceType":47,"resourceTypeDesc":48,"sizeBytes":49,"sourceHtmlUrl":50},"agents\u002Fopenai.yaml","REFERENCE","参考文档",100,"https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fbuilt-in-skills\u002Fcode-review\u002Fagents\u002Fopenai.yaml",[52,59,66,73,80,87],{"skillNo":53,"name":54,"nameZh":6,"description":55,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":9,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":56,"categories":57,"keywords":58,"publishedAt":18},"01M79JW5VYX2QR2404PD7WARKS","terminal-investigation","Bounded file discovery and terminal execution for a Computer Task Terminal Worker.","https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fpi-ext\u002Fpackages\u002Fcomputer-agent\u002Fskills\u002Fterminal-investigation\u002FSKILL.md",[],[],{"skillNo":60,"name":61,"nameZh":6,"description":62,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":9,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":63,"categories":64,"keywords":65,"publishedAt":18},"01M79JW2KXB8C795WKCMA3YQXH","procedure-learning","Compile verified Computer Task exploration into safe parameterized Procedure candidates.","https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fpi-ext\u002Fpackages\u002Fcomputer-agent\u002Fskills\u002Fprocedure-learning\u002FSKILL.md",[],[],{"skillNo":67,"name":68,"nameZh":6,"description":69,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":9,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":70,"categories":71,"keywords":72,"publishedAt":18},"01M79JVZ6B01YXQJNDRYQHMRY9","desktop-verification","Verify a Computer Task from a fresh observation without repairing or mutating the target.","https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fpi-ext\u002Fpackages\u002Fcomputer-agent\u002Fskills\u002Fdesktop-verification\u002FSKILL.md",[],[],{"skillNo":74,"name":75,"nameZh":6,"description":76,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":9,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":77,"categories":78,"keywords":79,"publishedAt":18},"01M79JVWSCCH7MKFKP9NJC4N4G","desktop-investigation","Locate desktop controls with semantic evidence and bounded visual fallback.","https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fpi-ext\u002Fpackages\u002Fcomputer-agent\u002Fskills\u002Fdesktop-investigation\u002FSKILL.md",[],[],{"skillNo":81,"name":82,"nameZh":6,"description":83,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":9,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":84,"categories":85,"keywords":86,"publishedAt":18},"01M79JVRFK3WVCKRCVZ0S1K0X8","cua-driver-operation","Operate PipiUI's pinned Cua Driver through snapshot, semantic locate, coherent action batch, and fresh verification.","https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fpi-ext\u002Fpackages\u002Fcomputer-agent\u002Fskills\u002Fcua-driver-operation\u002FSKILL.md",[],[],{"skillNo":88,"name":89,"nameZh":6,"description":90,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":9,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":91,"categories":92,"keywords":93,"publishedAt":18},"01M79JVMQP7N4SR5HP5QYWMZD3","computer-task-recovery","Replan after target loss, ambiguous location, unknown mutation outcome, or failed verification.","https:\u002F\u002Fgithub.com\u002FLeehow\u002Fpipiui\u002Fblob\u002Fmain\u002FElectron\u002Fresources\u002Fruntime\u002Fpi-ext\u002Fpackages\u002Fcomputer-agent\u002Fskills\u002Fcomputer-task-recovery\u002FSKILL.md",[],[]]