pr-comment-fact-check
STOP and fact-check PR review comments before applying or dismissing reviewer or bot feedback. Use on CodeRabbit, Copilot, Cursor bot, dependabot, or human reviewer comments.
- License 许可
- MIT
- 最近更新
- 2026-11-01
- Stars
- ★ 4
- Forks
- 0
01 前言 Front Matter
- name
- pr-comment-fact-check
- description
- STOP and fact-check PR review comments before applying or dismissing reviewer or bot feedback. Use on CodeRabbit, Copilot, Cursor bot, dependabot, or human reviewer comments.
02 资源文件 1
- 参考文档WORKFLOW.md10.8 KB
03 SKILL.md 正文
PR comment fact-check
STOP before applying or dismissing any PR comment. Each comment is a claim — verify against the actual code and this repo's authoritative sources (.agents/, docs/architecture.md, JSDoc, tests) before acting. Workflow: WORKFLOW.md.
| Verdict | Default action |
|---|---|
| ✅ Correct | Apply + resolve |
| ⚠️ Partial | Apply salvageable part + explain nuance |
| ❌ Hallucinated | Push back with evidence; resolve-on-merge-gate exception in WORKFLOW |
| 🕒 Outdated | Point at fix commit + resolve |
| 💭 Style | Apply if cheap, else defer |
Hallucination catalog (scrutinize harder)
Common LLM-reviewer patterns on this repo:
- "This isn't tested" without checking siblings — core contracts are pinned across
packages/core/src/layerStack.test.ts(open/dismiss/scope/gcTime/loadFn cancel, transitionsenteringDelay/exitingDelay/settle, blockersaddBlocker/dismissing/async veto,dismissAllmodes); each framework adapter has co-located tests underpackages/<fw>/src/; real-renderer paths spanpackages/*/tests-dom/**(vitest, rerender/detach — e.g. Reactconfirm.test.tsx,blocker.test.tsx,transition.test.tsx). Import isolation is enforced by package manifests,sherif, and workspace-awareknip, not anitImportsOnlyFromCoretest. Verify coverage before accepting. - Type-safety alarms — if
bun run typecheckpasses, the claim is almost always wrong, or about runtime behavior the type system can't see (then the reviewer must justify with the runtime case). - Generic "best practice" claims unsupported by our rules — "always destructure", "prefer interfaces over types", "add
useMemo/useCallback" — stylistic; we either have a rule or we don't. Grep.agents/for the convention. - Convention citations that don't exist — "this breaks the library's API conventions" — grep
.agents/+docs/architecture.md. If not codified, it's preference, not rule. - Memory-leak / race-condition claims with no concrete trigger — "this could leak" without a scenario is speculation; ask for the path. Real candidates here:
notifyManager.batchflushing,AbortControllercancel on dismiss,gcTimecache teardown,useSyncExternalStoreunmount-detach, the scope queue draining ondismissAll— demand the specific path. - Wrong API for our seam — bot suggests reaching into
LayerStackinternals from an adapter when the seam issubscribe/getSnapshot; suggests a per-adapter core fork when the core/adapter seam is meant to keep one engine across all frameworks. - Public-API suggestions that leak internals —
createCallContextis public and intentionally generic;Layer's#stateandLayerStack's#layers/#snapshot/#queuedSnapshot/#scopeQueue/#gcCache/#blockersare deliberately private. Push back on "export this helper" / "tighten this to the internal type".
Anti-patterns
- ❌ Applying every suggestion to clear the queue.
- ❌ Replying "fixed!" without verifying.
- ❌ Dismissing without evidence.
- ❌ Resolving a thread you rejected as hallucinated (the reviewer needs to see the receipts).
Reference
verify-after-each-step— run after applying a fix.harden-pr— optional full pass on the branch once comments are triaged.docs/architecture.md— seam model, public-surface policy, test matrix (authoritative for "is this the right seam / is this tested" claims).
04 同仓库更多 Skills
vue-layers
Vue adapter for @stainless-code/vue-layers; open UI from anywhere and manage ordered, named stacks with typed or fire-and-forget `open`
svelte-layers
Svelte bindings for @stainless-code/svelte-layers (runes + stores). Use to open overlay UI imperatively from anywhere, manage ordered named stacks, choose the Svelte 5.7+ runes or Svelte 3+ stores entry, and wire layer context or stack outlets.
solid-layers
SolidJS adapter for @stainless-code/solid-layers; open UI from anywhere and manage ordered, named stacks with typed or fire-and-forget `open`
react-layers
React adapter for @stainless-code/react-layers; open UI from anywhere and manage ordered, named stacks with typed or fire-and-forget `open`
preact-layers
Preact adapter for @stainless-code/preact-layers — use for awaitable confirm flows, singleton toasts, nested drawers, stack subscriptions, and custom layer hosts
lit-layers
Lit adapter for @stainless-code/lit-layers; open UI from anywhere and manage ordered, named stacks with typed or fire-and-forget `open` via Reactive Controllers and custom elements