localization-review
Reviews Swift/SwiftUI code for missing or incorrect String Catalog (.xcstrings) localization coverage, flags legacy NSLocalizedString/.strings usage, and — with approval — mechanically wraps flagged strings in String(localized:). Use when auditing localization coverage, before merging user-facing string changes, or migrating away from legacy .strings files.
- License 许可
- MIT
- 最近更新
- 2026-08-21
- Stars
- ★ 0
- Forks
- 0
01 前言 Front Matter
- name
- localization-review
- license
- MIT
- metadata
- { "author": "ICT", "version": "1.0" }
- description
- Reviews Swift/SwiftUI code for missing or incorrect String Catalog (.xcstrings) localization coverage, flags legacy NSLocalizedString/.strings usage, and — with approval — mechanically wraps flagged strings in String(localized:). Use when auditing localization coverage, before merging user-facing string changes, or migrating away from legacy .strings files.
- argument-hint
- [scope]
03 SKILL.md 正文
ICT iOS Team — This skill reviews code and, with approval, mechanically converts it to route through Xcode's String Catalog (
.xcstrings). It is a checker/converter only — it never generates translations for other languages.
1. Ask for scope
Ask the developer which scope to review, and wait for their answer before scanning anything:
- Diff scope — only the current commit / changes not yet merged into the base branch.
- Full scope — the entire project.
2. Locate the String Catalog
Find the project's .xcstrings file(s). If none exist, tell the developer no String Catalog was found and ask whether to proceed — findings can still surface, but nothing can be cross-checked against a catalog until one exists.
3. Scan
Scan the chosen scope using the rules in ${CLAUDE_SKILL_DIR}/references/detection-rules.md. In summary:
Text/Label/etc. fed aString-typed variable instead of a literal — the primary, sneakiest gap (SwiftUI'sText(_ content: some StringProtocol)overload renders plainStringvalues verbatim, not localized).- User-facing
Stringtext living outside the View layer (ViewModels, Models, error/alert messages) not wrapped inString(localized:). - Legacy
NSLocalizedString(...)calls — flagged as a modernization suggestion, not a hard gap. - Manual string concatenation/interpolation used to build user-facing text.
- Stray
.strings/.stringsdictfiles coexisting with a.xcstringscatalog. - Never flag string literals passed directly into
Text("..."),Label("...", ...), etc. — these already resolve toLocalizedStringKeyand Xcode auto-extracts them. Flagging these is noise.
4. Report findings
Present findings as a table:
| File | Line | Issue | Suggested Action |
|---|
Follow it with a summary line: total files scanned, total findings, legacy API count.
5. Cross-check against the String Catalog
Read ${CLAUDE_SKILL_DIR}/references/string-catalog-basics.md to understand how extraction works, then cross-reference flagged and existing localizable strings against the .xcstrings file itself:
- Confirm each expected key is actually present with the correct source-language value.
- Report mismatches plainly — e.g. a string wrapped in code but not yet extracted into the catalog needs an Xcode build to pick it up. This is expected right after a fix, not an error.
6. Wait for approval before changing anything
Do not wrap or modify any code until the developer explicitly approves. Show the findings table first and wait.
7. Apply (only after approval)
Apply only the mechanical fix: wrap the flagged literal/expression in String(localized:), keeping the existing source-language text exactly as-is. Never invent new copy, reword existing copy, or generate translations.
8. Final summary
Always end the run with:
- What was scanned (scope) and what was found/fixed.
- The String Catalog cross-check result.
- An explicit disclaimer: this is a review/checker only. It does not produce translations — any new key will show as
Newfor every non-source locale in the String Catalog until a human translator or localization vendor fills it in.
Core Instructions
- Never generate or guess translations into other languages — always out of scope.
- Never flag a direct string literal passed straight to a SwiftUI
Text/Labelinitializer — it's already correctly localizable. - Never apply a fix without explicit approval from the developer.
- Always state the detected scope (diff vs full project) before scanning.
- Always end with the String Catalog cross-check and the "checker only, not a translator" disclaimer.
References
${CLAUDE_SKILL_DIR}/references/detection-rules.md— full detection rule list with code examples (what to flag, what not to flag).${CLAUDE_SKILL_DIR}/references/string-catalog-basics.md— how Xcode String Catalogs and build-time extraction work, and why translation generation is out of scope.
04 同仓库更多 Skills
unit-testing
Writes or reviews iOS unit tests for data layer (Repository) and ViewModel code, following ICT's XCTest + Combine testing patterns.
unit-testing
Writes or reviews iOS unit tests for data layer (Repository) and ViewModel code, supporting both XCTest and Swift Testing frameworks. Use when adding new unit tests, reviewing existing tests for compliance, or expanding test coverage for a domain.
swiftui-reviewer
Comprehensively reviews SwiftUI code for best practices on modern APIs, maintainability, and performance. Use when reading, writing, or reviewing SwiftUI projects.
swiftui-reviewer
Comprehensively reviews SwiftUI code for best practices on modern APIs, maintainability, and performance. Use when reading, writing, or reviewing SwiftUI projects.
security-review
Comprehensive iOS security assessment for the ICT iOS team. Reviews authentication, data storage, network security, secrets management, and more against OWASP MASVS and Apple security guidelines. Use when auditing or reviewing iOS app security.
security-review
Comprehensive iOS security assessment for the ICT iOS team. Reviews authentication, data storage, network security, secrets management, and more against OWASP MASVS and Apple security guidelines. Use when auditing or reviewing iOS app security.