AGENT SKILL

review-verify

Internal run-it verification review pass of the agentic-workflow review pack — composed in-turn by review-change and product-audit; not a menu entry. Runs the project's gate and the changed behavior for real — commands, exit codes, observed output — instead of assuming; what cannot be executed goes to the manual checklist. Findings only; never edits code.

License 许可
MIT
最近更新
2026-11-15
Stars
★ 23
Forks
4

01 前言 Front Matter

name
review-verify
author
Gabriel Trabanco <1969593+gtrabanco@users.noreply.github.com>
license
MIT
version
4.10.0
description
Internal run-it verification review pass of the agentic-workflow review pack — composed in-turn by review-change and product-audit; not a menu entry. Runs the project's gate and the changed behavior for real — commands, exit codes, observed output — instead of assuming; what cannot be executed goes to the manual checklist. Findings only; never edits code.
user-invocable
false

03 SKILL.md 正文

Review Verify (internal)

Runner commands below are bunx @gtrabanco/agentic-workflow@<pin> … — read <pin> from references/RUNNER.md. It is stamped at release and never guessed: a hard-coded version re-opens the per-release sweep the contract removes, and latest is not a legal pin.

Composed by review-change / product-audit within their conversation — on any agent, follow this file inline as the routed step. Findings only; never edits, never refactors.

Shift from discoverer to auditor of recorded evidence (S5). The implementer's claim-evidence loop is the primary verification. This review audits the recorded evidence: re-runs a sample of the recorded commands instead of re-deriving the whole change. This is the cost-scaling invariant — reviewers dig into code only when evidence is absent or contradicts.

Scope

The caller's diff or path/glob — the shape is the finder contract's (skills/review-implementation/references/FINDER_CONTRACT.md, this section's owner). State the scope at the top of the returned table.

Checklist (evaluate EVERY item — none is optional; n/a must be stated)

✓ Evidence audit. Sample the unit doc's Evidence rows: re-run ≥ 3 of the recorded commands and compare observed output against what the implementer recorded. Mismatch → finding: "evidence contradicts observation at <file:line>". ✓ Claim-evidence loop verification. Check the fold's claim table (if present): every row has status: ✓. Any ✗ row means the implementer's turn did not complete its claim-evidence loop. ✓ Unit-route triage currency. Re-run bunx @gtrabanco/agentic-workflow@<pin> unit-route --triage <slug> and compare the Steps: line against the unit doc's Evidence section. Mismatch → stale triage. ✓ Gate evidence is consumed, not re-run. Run bun scripts/gate-receipt.mjs verify; it answers the receipt's state: current + pass (exit 0) means the declared closure has not moved — cite its checks[] ids and manifest.digest as the gate evidence; missing (3), stale (4) or invalid (5) is a finding routed to bun scripts/gate-receipt.mjs run, never a prompt to run the gate from this review and never an implicit pass; a current fail/degraded receipt fails the review with the failing check ids and their fragments ✓ The change's primary claimed behavior was exercised for real (run the CLI/endpoint/function; paste the actual observed output) — in addition to the evidence audit, verify at least one behavioral claim not covered by recorded evidence ✓ At least one failure-mode from the SPEC's dev scenarios was reproduced (bad input, missing file, error path) and behaved as specified ✓ New/changed tests actually fail when the implementation is reverted or broken (mutate or stash to prove they assert something — restore after) ✓ No test was skipped/disabled to get green (grep for skip/only/todo markers in the diff) ✓ The build artifact/dev server starts cleanly (no new warnings that indicate breakage) ✓ Anything that can only be confirmed by a human (visual, device, locale, load) is listed explicitly under "Manual" — never silently dropped

Materiality bar

The bar is owned by skills/review-implementation/references/FINDER_CONTRACT.md — apply it as written: cite the rule it violates beside the evidence; never pad the table.

Return exactly

Sev and Impact are the two published closed sets (BLOCKER | CRITICAL | WARNING | SUGGESTION and blocking | docs-only | report-only); their meanings are owned by review-implementation (CLASSIFY.md §Severity ladder) — assign a token, never a prose grade.

REVIEW VERIFY — scope: <scope>

| # | Finding | Sev | Impact | Evidence | Suggested fix |
|---|---------|-----|--------|----------|---------------|
| 1 | <what>  | BLOCKER|CRITICAL|WARNING|SUGGESTION | blocking|docs-only|report-only | <file:line> | <smallest action> |

Checklist: <n> evaluated, <n> pass, <n> findings, <n> n/a (<which + why>)
Summary: <1-2 sentences>
Manual (a human must check): <bullet list, or "none">
Decision: PASS | FAIL

FAIL if any BLOCKER, CRITICAL or WARNING finding is open; PASS otherwise. SUGGESTION findings never block — they route to the caller's triage step.

Done when

  • Every checklist item was evaluated with evidence (file:line or command output) or explicitly marked n/a with the reason.
  • The fixed-format block above is returned — nothing more, nothing less — and no code was changed.

04 同仓库更多 Skills

gtrabanco
gtrabanco/agentic-workflow

runner-contract

The distributable runner's invocation contract: one train-stamped pin for every runtime command the workflow's skills cite. Referenced by the skills that run sensors, guards and ceremony operations; never a menu entry.

★ 23
gtrabanco
gtrabanco/agentic-workflow

verification-contract

Internal contract: the acceptance artifact per delivery unit — legacy (pre- feature 61) units may carry a frozen `ACCEPTANCE.md` (binding if present); post-feature 61 units use the unit doc's `## Acceptance criteria` section as the canonical acceptance source; the unit doc's evidence carrier — `## Evidence` table, or `## Log` `E` lines for a re-cut unit (#308) — serves as the execution receipt. Consumed by planners, execute-phase, and review-change.

★ 23
gtrabanco
gtrabanco/agentic-workflow

skill-lint

Internal agentic-workflow maintenance: after SKILL.md edits, lint the repo's authoring rules, the machine-surface registration rules and the skill-content smell/security checks. Triggers: "lint the skill", "skill authoring check", "check the skill rules", "scan skills for smells".

★ 23
gtrabanco
gtrabanco/agentic-workflow

review-seo

Internal SEO review pass of the agentic-workflow review pack — composed in-turn by review-change and product-audit; not a menu entry. Checks changed web pages/routes for indexability, metadata, and structured data — applies only to public web surfaces. Findings only; never edits code.

★ 23
gtrabanco
gtrabanco/agentic-workflow

review-security

Internal security review pass of the agentic-workflow review pack — composed in-turn by review-change and product-audit; not a menu entry. Checks secrets, input validation, injection, authn/authz, PII exposure, and dependency risk on the changed surface. Findings only; never edits code.

★ 23
gtrabanco
gtrabanco/agentic-workflow

review-perf

Internal performance review pass of the agentic-workflow review pack — composed in-turn by review-change and product-audit; not a menu entry. Checks the changed paths for algorithmic and resource regressions: N+1s, hot-path allocations, asset weight, and leaks. Findings only; never edits code.

★ 23