ship-pr
Use when a change is implemented and needs to land as a PR — branching, evidence, commits, PR creation, CI watching, or when CI jobs fail and you must decide rerun-vs-fix. Also use when a "green" claim is about to be made.
- License 许可
- MPL-2.0
- 最近更新
- 2026-11-01
- Stars
- ★ 1
- Forks
- 0
01 前言 Front Matter
- name
- ship-pr
- description
- Use when a change is implemented and needs to land as a PR — branching, evidence, commits, PR creation, CI watching, or when CI jobs fail and you must decide rerun-vs-fix. Also use when a "green" claim is about to be made.
03 SKILL.md 正文
Ship a PR
Operational sequence for landing work under continuous release (ADR 0090/0096: merge = release; the PR's required checks are the only gate). Rules live in engineering-workflow.md (Definition of Done, §K evidence) — this skill is the command-level ritual.
Sequence
- Branch from a fresh master:
git checkout master && git pull --ff-only && git checkout -b <type>/<slug>. - Implement; iterate with targeted runs (the DoD's which-test-where map), one heavy suite at a time.
- Evidence before handover (§K — the recurring failure this skill exists for):
make check-localunder Nix; green = the recipe's own finalCHECK_LOCAL_EXIT=0line. A wrapper/pipe exit code is NEVER evidence (it reflectstail, notmake).make check-docs-gatesseparately — check-local does not cover docs gates (caught live: MCP catalog drift reached CI, #346).- Re-run after the last edit; never hand over a stale run.
- Simplification pass before committing: run the over-engineering review (
/ponytail-reviewwhen the plugin is available) on the diff — delete speculative abstractions, reinvented helpers, dead flexibility. The repo's own contract (tests-that-redden, proptest/insta for transforms, doc updates) is requested work, never a simplification target. - Commits: Conventional, single
[a-z0-9._-]+scope, English. Zero AI attribution anywhere on the forge — commits, trailers, PR bodies (a footer slipped into PR #349 and had to be scrubbed; check before and aftergh pr create). - PR:
gh pr create --label "release:<major|minor|patch|skip>"— the agent sets the proposed label matching scope (CLAUDE.md § continuous release); merging and the final label call stay owner-only. Body: what/why, guardrails added, honest §K evidence block (what ran, what did NOT). - Watch CI to the exact head SHA (
gh pr checks <n>; confirmheadRefOidmatches your push). Poll loop:
Wait only onfor i in $(seq 1 60); do out=$(gh pr checks <n>); \ echo "$out" | grep -q "pending" || break; sleep 30; donepending— never onskipping: skipped jobs are terminal (a docs-only PR keeps them forever and still satisfies required checks), so a loop that waits forskippingto clear hangs to timeout.
Failure triage (decide class BEFORE touching anything)
| Signal | Class | Action |
|---|---|---|
| Fails in Set up job ("Failed to resolve action download info", "Service Unavailable"), or second-long jobs dying after minutes | GitHub infra | Check https://www.githubstatus.com/api/v2/status.json; wait out indicator: major, then gh run rerun <id> --failed |
| Job runs your step and asserts | Real | Fix on the branch; fix the class (guardrail-harvest), never weaken the gate |
| Known flake signature, local green | Flake | One rerun + file/annotate the tracked flake issue — never a blind timeout bump |
Common mistakes
- Claiming green off a local run or a partial log — a failed stage aborts later stages; only the marker/
gh pr checkscount. - Merging, editing
release:*post-creation, version bumps, changelog edits — all owner/automation-only. - Fixing "infra" failures by changing code, or rerunning real failures hoping they pass.
04 同仓库更多 Skills
repoctx
Use repoctx for fast, indexed code navigation in this repo. Beats grep/find/cat on structural questions about symbols, definitions, the call graph (who-calls / callees / callgraph), and surrounding source.
packaging
Build and smoke-test Brawler release artifacts — portable Windows .exe from Linux/WSL via cargo-xwin, Linux .deb/.rpm/AppImage, native Windows fallback. Use for packaging, cross-build verification, or Windows hands-on testing paths.
investing-domain
Domain lens for designing/building Brawler — how an equity investor actually reads companies (fundamental analysis, quality assessment, GPW specifics). Load when designing UI hierarchies, panels, journeys, or analytics for company data.
guardrail-harvest
Convert a flagged defect's class into a durable guardrail — a precise automated gate or a documented rule + checklist line — in the same change. Use whenever the user, a review, or a failing gate flags a defect.
brawler-mcp
Use when you (an AI agent) are connected to Brawler over its MCP server and need to read the user's investment research or write back into it — including acquiring KPIs from an issuer report ("process all pending KPI ingests", staging observations, resuming a pending run, a lease that expired, a validation that failed). Covers tool discovery, the read/act tiers, mandatory-source (provenance) rules, the KPI-ingest run workflow, internal-id conventions, the permanent denylist, and safe read→analyze→write sequences. Load it before your first tools/call against Brawler.
brawler-design
Use before ANY Brawler UI work — writing/changing JSX, drawing a mockup, styleguide or visual-language work, choosing colors/typography/labels, designing a panel or empty state. Binds the generic design skills to Brawler's normative design language (ADR 0104) and authoring contract.