[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M74GGN6GNWXQACYGDHT3SSC4":3,"skill-same:01M74GGN6GNWXQACYGDHT3SSC4":44},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":16,"categories":17,"keywords":18,"publishedAt":19,"linkOnly":20,"markdownContent":21,"markdownBody":22,"frontMatter":23,"refName":24,"commitSha":25,"skillDirectory":26,"forksCount":14,"repositoryHtmlUrl":27,"repositoryHomepageUrl":6,"ownerHtmlUrl":28,"ownerBlogUrl":6,"ownerDescription":6,"updatedAt":29,"install":30,"resources":43},"01M74GGN6GNWXQACYGDHT3SSC4","test-smell",null,"Detect test smells\u002Fanti-patterns — over-mocking, fragile assertions, slow setup, flaky timing; flag each with its layer and a refactor. Reviews existing tests, not authoring them (unit-tests).","MohammadBafkar\u002Fpolymath","MohammadBafkar","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F34940462?v=4","01M74G540TQFZWK6KVAPKFVGNR","Mohammad Bafkar","01M74G541HG19QP9V5DQCJVKYE",0,"MIT","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-qa\u002Fskills\u002Ftest-smell\u002FSKILL.md",[],[],"2026-11-11 15:11:14",false,"---\nname: test-smell\ndescription: Detect test smells\u002Fanti-patterns — over-mocking, fragile assertions, slow setup, flaky timing; flag each with its layer and a refactor. Reviews existing tests, not authoring them (unit-tests).\n---\n\n# test-smell\n\n> Read an existing test suite the way a reviewer would — find the tests that will rot, mislead, or flake, and say how to fix each.\n\n**Mode:** analytical — judgment inside a fixed frame. Keep the output shape; every verdict cites its evidence; unknowns are marked `[TBD]` or `[VERIFY]`, never filled in.\n\n## When to use\n\n- A test suite is slow, flaky, or brittle and you want the *causes*, not just a green\u002Fred.\n- Reviewing a test file or test diff for quality (distinct from reviewing the production code).\n- A workflow invokes `polymath-qa:test-smell`.\n\nThis scans *existing* tests. It does not write tests (`polymath-qa:unit-tests`), find untested behavior (`polymath-qa:coverage-gap`), or judge assertion strength specifically (`polymath-qa:assertion-quality`).\n\n## Inputs\n\n- The test files or test diff to review.\n- Optionally the production code under test, to judge over-coupling.\n\n## Smells to flag\n\n- **Over-mocking** — mocking internal collaborators; the test asserts the mock, not behavior.\n- **Fragile assertions** — asserting incidental output (full strings, ordering, timestamps) that breaks on unrelated change.\n- **Eager \u002F multi-behavior tests** — one test covering several behaviors; unclear reason-to-fail.\n- **Slow setup** — per-test heavy fixtures, real I\u002FO where a seam would do.\n- **Flaky timing** — `sleep`, wall-clock, ordering, shared mutable state across tests.\n- **Test interdependence** — tests that pass only in a given order or share state.\n- **Misplaced layer** — an integration concern tested as a unit (or vice versa).\n\n## Procedure\n\n1. Read the tests; for each smell found, cite the test by name and the line\u002Fpattern.\n2. Name the layer the test *should* live at (unit \u002F integration \u002F e2e) if misplaced.\n3. Recommend a concrete refactor per finding (introduce a seam, narrow the assertion, hoist setup, remove the sleep).\n4. Rank findings by blast radius (flake-causing > brittle > slow > cosmetic).\n\n## Output\n\nFindings ranked by blast radius (flake-causing > brittle > slow > cosmetic), then file order:\n\n```text\nTest smells: tests\u002F (38 tests, 5 findings)\n\n1. FLAKY TIMING      tests\u002Ftest_worker.py::test_job_retries  (line 22: time.sleep(2))\n   layer: unit (correct)\n   fix:   inject a fake clock; assert on the scheduled retry time, not wall time\n\n2. INTERDEPENDENCE   tests\u002Ftest_cart.py::test_checkout  (reads the cart created by test_add_item)\n   fix:   create the cart in this test's own fixture\n\n3. OVER-MOCKING      tests\u002Ftest_refunds.py::test_refund  (mocks RefundRepository, an internal collaborator)\n   layer: should be integration (real repository on a test DB)\n   fix:   replace the mock with the repository on testcontainers postgres\n\n4. FRAGILE           tests\u002Ftest_report.py::test_render  (asserts the whole 2 KB HTML string)\n   fix:   assert the three totals and the title only\n\n5. SLOW SETUP        tests\u002Fconftest.py::db  (migrates a fresh DB per test, ~1.4 s each)\n   fix:   session-scoped migration + per-test transaction rollback\n\nNo smell: 33 tests.\n```\n\n## Quality bar\n\n- Every finding cites a specific test, not \"the suite generally\".\n- Each finding pairs the smell with a concrete fix and the correct layer.\n- Does not propose rewriting passing tests with no smell — churn is not a finding.\n","# test-smell\n\n> Read an existing test suite the way a reviewer would — find the tests that will rot, mislead, or flake, and say how to fix each.\n\n**Mode:** analytical — judgment inside a fixed frame. Keep the output shape; every verdict cites its evidence; unknowns are marked `[TBD]` or `[VERIFY]`, never filled in.\n\n## When to use\n\n- A test suite is slow, flaky, or brittle and you want the *causes*, not just a green\u002Fred.\n- Reviewing a test file or test diff for quality (distinct from reviewing the production code).\n- A workflow invokes `polymath-qa:test-smell`.\n\nThis scans *existing* tests. It does not write tests (`polymath-qa:unit-tests`), find untested behavior (`polymath-qa:coverage-gap`), or judge assertion strength specifically (`polymath-qa:assertion-quality`).\n\n## Inputs\n\n- The test files or test diff to review.\n- Optionally the production code under test, to judge over-coupling.\n\n## Smells to flag\n\n- **Over-mocking** — mocking internal collaborators; the test asserts the mock, not behavior.\n- **Fragile assertions** — asserting incidental output (full strings, ordering, timestamps) that breaks on unrelated change.\n- **Eager \u002F multi-behavior tests** — one test covering several behaviors; unclear reason-to-fail.\n- **Slow setup** — per-test heavy fixtures, real I\u002FO where a seam would do.\n- **Flaky timing** — `sleep`, wall-clock, ordering, shared mutable state across tests.\n- **Test interdependence** — tests that pass only in a given order or share state.\n- **Misplaced layer** — an integration concern tested as a unit (or vice versa).\n\n## Procedure\n\n1. Read the tests; for each smell found, cite the test by name and the line\u002Fpattern.\n2. Name the layer the test *should* live at (unit \u002F integration \u002F e2e) if misplaced.\n3. Recommend a concrete refactor per finding (introduce a seam, narrow the assertion, hoist setup, remove the sleep).\n4. Rank findings by blast radius (flake-causing > brittle > slow > cosmetic).\n\n## Output\n\nFindings ranked by blast radius (flake-causing > brittle > slow > cosmetic), then file order:\n\n```text\nTest smells: tests\u002F (38 tests, 5 findings)\n\n1. FLAKY TIMING      tests\u002Ftest_worker.py::test_job_retries  (line 22: time.sleep(2))\n   layer: unit (correct)\n   fix:   inject a fake clock; assert on the scheduled retry time, not wall time\n\n2. INTERDEPENDENCE   tests\u002Ftest_cart.py::test_checkout  (reads the cart created by test_add_item)\n   fix:   create the cart in this test's own fixture\n\n3. OVER-MOCKING      tests\u002Ftest_refunds.py::test_refund  (mocks RefundRepository, an internal collaborator)\n   layer: should be integration (real repository on a test DB)\n   fix:   replace the mock with the repository on testcontainers postgres\n\n4. FRAGILE           tests\u002Ftest_report.py::test_render  (asserts the whole 2 KB HTML string)\n   fix:   assert the three totals and the title only\n\n5. SLOW SETUP        tests\u002Fconftest.py::db  (migrates a fresh DB per test, ~1.4 s each)\n   fix:   session-scoped migration + per-test transaction rollback\n\nNo smell: 33 tests.\n```\n\n## Quality bar\n\n- Every finding cites a specific test, not \"the suite generally\".\n- Each finding pairs the smell with a concrete fix and the correct layer.\n- Does not propose rewriting passing tests with no smell — churn is not a finding.\n",{"name":5,"description":7},"main","23f6e21841a39580c9da2b5ec941f39dda17cd86","plugins\u002Fpolymath-qa\u002Fskills\u002Ftest-smell","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath","https:\u002F\u002Fgithub.com\u002FMohammadBafkar","2026-10-29 18:34:59",{"source":8,"skillName":5,"commands":31,"prompt":41,"zipAvailable":42},[32,35,38],{"tool":33,"command":34},"npx","npx skills add MohammadBafkar\u002Fpolymath --skill test-smell",{"tool":36,"command":37},"bunx","bunx skills add MohammadBafkar\u002Fpolymath --skill test-smell",{"tool":39,"command":40},"pnpm","pnpm dlx skills add MohammadBafkar\u002Fpolymath --skill test-smell","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-qa\u002Fskills\u002Ftest-smell\u002FSKILL.md",true,[],[45,52,59,66,73,80],{"skillNo":46,"name":47,"nameZh":6,"description":48,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":49,"categories":50,"keywords":51,"publishedAt":19},"01M74GN87EBRHM9N87M7AP1HDD","runbook","Write or refresh an operational runbook for an alert\u002Fsymptom; structured as TL;DR + Pre-checks + Steps + Verification + Rollback + Escalation.","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-writing\u002Fskills\u002Frunbook\u002FSKILL.md",[],[],{"skillNo":53,"name":54,"nameZh":6,"description":55,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":56,"categories":57,"keywords":58,"publishedAt":19},"01M74GN5GPKEC1JEKP2DFQNEQJ","rfc","Draft a lightweight design RFC to docs\u002Frfcs\u002F\u003Cslug>.md; Summary, Motivation, Detailed design, Drawbacks, Alternatives, Unresolved questions. A proposal to debate, not a recorded decision (adr).","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-writing\u002Fskills\u002Frfc\u002FSKILL.md",[],[],{"skillNo":60,"name":61,"nameZh":6,"description":62,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":63,"categories":64,"keywords":65,"publishedAt":19},"01M74GN2F4CWPMV4X09TG4E304","editorial-pass","Review and tighten prose in a Markdown artifact for a target tone (terse, formal, friendly) without dropping information; preserve quotations and load-bearing constraints.","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-writing\u002Fskills\u002Feditorial-pass\u002FSKILL.md",[],[],{"skillNo":67,"name":68,"nameZh":6,"description":69,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":70,"categories":71,"keywords":72,"publishedAt":19},"01M74GMZWGYMZ37C4DYGT6P23G","architecture-review-facilitation","Run an architecture review as a process — entry criteria, reviewer checklist, decision log, and follow-up actions — pairing the design artifact with a red-team pass.","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-writing\u002Fskills\u002Farchitecture-review-facilitation\u002FSKILL.md",[],[],{"skillNo":74,"name":75,"nameZh":6,"description":76,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":77,"categories":78,"keywords":79,"publishedAt":19},"01M74GMXVX0YX3ETDXS527XDGM","architecture-doc","Write a C4-style architecture document; System Context + Containers (+ Components when interesting) with mermaid diagrams. Describes structure, not a decision (adr) or proposal (rfc).","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-writing\u002Fskills\u002Farchitecture-doc\u002FSKILL.md",[],[],{"skillNo":81,"name":82,"nameZh":6,"description":83,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":84,"categories":85,"keywords":86,"publishedAt":19},"01M74GMVG1WSMCK066S3KE6V5K","adr","Write an Architecture Decision Record (Michael Nygard format) to docs\u002Fadrs\u002FNNNN-\u003Cslug>.md; frontmatter validated by the ADR artifact schema. Records a made decision, not a proposal to debate (rfc).","https:\u002F\u002Fgithub.com\u002FMohammadBafkar\u002Fpolymath\u002Fblob\u002Fmain\u002Fplugins\u002Fpolymath-writing\u002Fskills\u002Fadr\u002FSKILL.md",[],[]]