[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M74FWFA5Z7ATVWCGCATAWRJP":3,"skill-same:01M74FWFA5Z7ATVWCGCATAWRJP":49},{"skillNo":4,"name":5,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":7,"ownerLogin":8,"ownerAvatarUrl":9,"ownerAccountNo":10,"ownerDisplayName":11,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":15,"categories":16,"keywords":17,"publishedAt":18,"linkOnly":19,"markdownContent":20,"markdownBody":20,"frontMatter":21,"refName":22,"commitSha":23,"skillDirectory":24,"forksCount":13,"repositoryHtmlUrl":25,"repositoryHomepageUrl":6,"ownerHtmlUrl":26,"ownerBlogUrl":6,"ownerDescription":27,"updatedAt":28,"install":29,"resources":42},"01M74FWFA5Z7ATVWCGCATAWRJP","two-axis-code-review",null,"Astrumon\u002Fspovishun-skills","Astrumon","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F67917191?v=4","01M74FSGPFMM3XWY2PMSEN8Z2W","Danylo Bidnyk","01M74FSGQ12JX4QM4FEY6NEH6N",0,"MIT","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Fskills\u002Ftwo-axis-code-review\u002FSKILL.md",[],[],"2026-11-11 15:11:14",false,"# Two-Axis Code Review (Standards + Spec)\n\nTwo-axis review of the diff between `HEAD` and a fixed point (default: `develop`):\n\n- **Standards** — does the code conform to this project's documented standards (CLAUDE.md, Kotlin rules, Clean Architecture) and the smell baseline?\n- **Spec** — does the code faithfully implement the originating Notion task (Goal \u002F Steps \u002F Definition of Done)?\n\nBoth axes run as **parallel sub-agents** so they don't pollute each other's context, then this skill aggregates their findings side by side. Both reports are written **in Ukrainian**.\n\n## Scope\n\nThis skill covers **Spec conformance + architectural\u002Fstyle standards ONLY**. Out of scope — do NOT report:\n\n- Bugs, logic errors, silent failures\n- Test coverage and test quality\n- Type design\n- Database migrations, transactions, indexes, N+1\n\nThose belong to the dedicated review agents (`kotlin-reviewer`, `code-architecture-reviewer`, `database-reviewer`) and the `code-reviewer` skill. Do not duplicate their work.\n\n## Process\n\n### 1. Pin the fixed point\n\nDefault fixed point is **`develop`** — do not ask the user for it. Only use a different ref (commit SHA, branch, tag, `HEAD~5`, …) if the user explicitly supplied one.\n\n- Confirm the ref resolves: `git rev-parse develop` (if it fails, try `origin\u002Fdevelop`; use whichever resolves as `\u003Cfixed-point>` below).\n- Capture the diff once: `git diff \u003Cfixed-point>...HEAD` (three-dot — comparison is against the merge-base).\n- Note the commit list: `git log \u003Cfixed-point>..HEAD --oneline`.\n\nA bad ref or an empty diff should fail here — not inside two parallel sub-agents.\n\n### 2. Resolve the spec from Notion\n\nThe spec is the originating Notion task, resolved from the branch name:\n\n1. Get the current branch: `git rev-parse --abbrev-ref HEAD`.\n2. Extract the task number `N` from the `feature\u002F{{PROJECT_PREFIX}}-N-*` pattern.\n3. Fetch the task:\n   ```\n   node .claude\u002Fscripts\u002Fnotion\u002Fget-task.js {{PROJECT_PREFIX}}-N --format=json\n   ```\n4. The spec = the task's **Goal**, **Steps**, and **Definition of Done** sections.\n\nFallbacks, in order:\n\n- If the user passed a task id (`{{PROJECT_PREFIX}}-N`, bare `N`, or a Notion pageId) as an argument — use it instead of branch parsing.\n- If the branch doesn't match the pattern and no argument was given — ask the user which task this branch implements.\n- If there is genuinely no task, skip the Spec sub-agent and state \"спеки немає\" in the final report.\n\n### 3. Identify the standards sources\n\nRead these files (skip any that are missing — do not fail):\n\n- `CLAUDE.md` (project root)\n- `.claude\u002Frules\u002Fkotlin\u002F*.md` (glob — take every file present)\n- `.claude\u002Frules\u002Fcommon\u002Fdesign-principles.md`\n\nOn top of the documented standards, the Standards axis always carries the **smell baseline** below — a fixed set of Fowler code smells (_Refactoring_, ch.3) plus a Kotlin\u002FClean-Architecture checklist. Two rules bind it:\n\n- **The repo overrides.** A documented project standard always wins; where it endorses something the baseline would flag, suppress the smell.\n- **Always a judgement call.** Each smell is a labelled heuristic (\"possible Feature Envy\"), never a hard violation — and, like any standard here, skip anything tooling already enforces (detekt, ktlint).\n\nEach item reads *what it is* → *how to fix*; match it against the diff.\n\n**Fowler baseline:**\n\n- **Mysterious Name** — a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.\n- **Duplicated Code** — the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.\n- **Feature Envy** — a method that reaches into another object's data more than its own. → move the method onto the data it envies.\n- **Data Clumps** — the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.\n- **Primitive Obsession** — a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.\n- **Repeated Switches** — the same `when`\u002F`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.\n- **Shotgun Surgery** — one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.\n- **Divergent Change** — one file or module is edited for several unrelated reasons. → split so each module changes for one reason.\n- **Speculative Generality** — abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.\n- **Message Chains** — long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.\n- **Middle Man** — a class or function that mostly just delegates onward. → cut it, call the real target direct.\n- **Refused Bequest** — a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.\n\n**Kotlin \u002F Clean Architecture checklist:**\n\n- **Layer-boundary violation** — a dependency that doesn't point inward (`presentation → domain ← data`); e.g. domain importing from data or presentation. → invert it behind an interface owned by domain.\n- **Framework leak into domain** — Ktor, Exposed, Koin, serialization, or other framework types inside the domain layer. → move them to data\u002Fpresentation; domain stays pure Kotlin.\n- **Callback instead of coroutine** — a callback\u002Flistener API where `suspend fun` or `Flow` fits. → convert to suspend\u002FFlow.\n- **Non-idiomatic Kotlin** — a plain class where `data class`\u002F`sealed class` fits, an `if`-cascade where `when` fits, Java-style getters\u002Fsetters\u002Fbuilders. → use the idiomatic form.\n\n### 4. Spawn both sub-agents in parallel\n\nSend a single message with two `Agent` tool calls. Use the `general-purpose` subagent for both.\n\n**Standards sub-agent prompt** — include:\n\n- The full diff command and commit list.\n- The list of standards-source files you found in step 3, **plus the full smell baseline and Kotlin\u002FClean-Architecture checklist from step 3** pasted in full — the sub-agent has no other access to them.\n- The out-of-scope list from the Scope section — findings must not drift into bug-hunting, tests, types, or DB.\n- The brief: \"Напиши звіт українською мовою. Report — per file\u002Fhunk where relevant — (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) any baseline smell or checklist item you spot: name it and quote the hunk. Distinguish hard violations from judgement calls — documented-standard breaches can be hard, but baseline smells are always judgement calls, and a documented project standard overrides the baseline. Skip anything tooling enforces. Under 400 words.\"\n\n**Spec sub-agent prompt** — include:\n\n- The diff command and commit list.\n- The fetched spec: the task's Goal, Steps, and Definition of Done, pasted in full.\n- The out-of-scope list from the Scope section.\n- The brief: \"Напиши звіт українською мовою. Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong. Quote the spec line for each finding. Under 400 words.\"\n\nIf the spec is missing, skip the Spec sub-agent and note this in the final report.\n\n### 5. Aggregate\n\nPresent the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings — the two axes are deliberately separate (see _Why two axes_).\n\nEnd with a one-line summary per axis: total findings and the worst issue _within that axis_ (if any). Don't pick a single winner across axes — that's the reranking the separation exists to prevent.\n\n## Why two axes\n\nA change can pass one axis and fail the other:\n\n- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**\n- Code that does exactly what the task asked but breaks the project's conventions → **Spec pass, Standards fail.**\n\nReporting them separately stops one axis from masking the other.\n",{},"main","4ad702b3d4f403306c1a016277020693dd669f55","skills\u002Ftwo-axis-code-review","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills","https:\u002F\u002Fgithub.com\u002FAstrumon","Software Engineer","2026-10-14 01:01:46",{"source":7,"skillName":5,"commands":30,"prompt":40,"zipAvailable":41},[31,34,37],{"tool":32,"command":33},"npx","npx skills add Astrumon\u002Fspovishun-skills --skill two-axis-code-review",{"tool":35,"command":36},"bunx","bunx skills add Astrumon\u002Fspovishun-skills --skill two-axis-code-review",{"tool":38,"command":39},"pnpm","pnpm dlx skills add Astrumon\u002Fspovishun-skills --skill two-axis-code-review","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Fskills\u002Ftwo-axis-code-review\u002FSKILL.md",true,[43],{"path":44,"resourceType":45,"resourceTypeDesc":46,"sizeBytes":47,"sourceHtmlUrl":48},"manifest.yaml","REFERENCE","参考文档",881,"https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Fskills\u002Ftwo-axis-code-review\u002Fmanifest.yaml",[50,56,62,69,74,79],{"skillNo":51,"name":52,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":7,"ownerLogin":8,"ownerAvatarUrl":9,"ownerAccountNo":10,"ownerDisplayName":11,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":53,"categories":54,"keywords":55,"publishedAt":18},"01M74FX71JH2KNG5KX7TZHSKCB","universal-skill","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Ftest\u002Ffixtures\u002Fsource\u002Fskills\u002Funiversal-skill\u002FSKILL.md",[],[],{"skillNo":57,"name":58,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":7,"ownerLogin":8,"ownerAvatarUrl":9,"ownerAccountNo":10,"ownerDisplayName":11,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":59,"categories":60,"keywords":61,"publishedAt":18},"01M74FX57GTEFPJVCPWPSP6CCW","notion-skill","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Ftest\u002Ffixtures\u002Fsource\u002Fskills\u002Fnotion-skill\u002FSKILL.md",[],[],{"skillNo":63,"name":64,"nameZh":6,"description":65,"descriptionZh":6,"repositoryFullName":7,"ownerLogin":8,"ownerAvatarUrl":9,"ownerAccountNo":10,"ownerDisplayName":11,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":66,"categories":67,"keywords":68,"publishedAt":18},"01M74FX30F3K8906P5ASQ3DNXR","inline-frontmatter-skill","Hand-authored description that already lives in the body and must not be double-wrapped.","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Ftest\u002Ffixtures\u002Fsource\u002Fskills\u002Finline-frontmatter-skill\u002FSKILL.md",[],[],{"skillNo":70,"name":52,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":7,"ownerLogin":8,"ownerAvatarUrl":9,"ownerAccountNo":10,"ownerDisplayName":11,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":71,"categories":72,"keywords":73,"publishedAt":18},"01M74FX18AGHM2KHQ502PMJZRJ","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Ftest\u002Ffixtures\u002Fsource-v2\u002Fskills\u002Funiversal-skill\u002FSKILL.md",[],[],{"skillNo":75,"name":58,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":7,"ownerLogin":8,"ownerAvatarUrl":9,"ownerAccountNo":10,"ownerDisplayName":11,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":76,"categories":77,"keywords":78,"publishedAt":18},"01M74FWZJ193G810P0ZJ1PKEZ9","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Ftest\u002Ffixtures\u002Fsource-v2\u002Fskills\u002Fnotion-skill\u002FSKILL.md",[],[],{"skillNo":80,"name":81,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":7,"ownerLogin":8,"ownerAvatarUrl":9,"ownerAccountNo":10,"ownerDisplayName":11,"repositoryNo":12,"starsCount":13,"licenseSpdxId":14,"licenseFileUrl":6,"sourceHtmlUrl":82,"categories":83,"keywords":84,"publishedAt":18},"01M74FWPNEZWWGQ2Q37N6MMWP1","write-a-skill","https:\u002F\u002Fgithub.com\u002FAstrumon\u002Fspovishun-skills\u002Fblob\u002Fmain\u002Fskills\u002Fwrite-a-skill\u002FSKILL.md",[],[]]