[{"data":1,"prerenderedAt":-1},["ShallowReactive",2],{"skill:01M72S6SWSDXFB7KEC5TZY6NH0":3,"skill-same:01M72S6SWSDXFB7KEC5TZY6NH0":47},{"skillNo":4,"name":5,"nameZh":6,"description":7,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":16,"categories":17,"keywords":18,"publishedAt":19,"linkOnly":20,"markdownContent":21,"markdownBody":22,"frontMatter":23,"refName":25,"commitSha":26,"skillDirectory":27,"forksCount":14,"repositoryHtmlUrl":28,"repositoryHomepageUrl":6,"ownerHtmlUrl":29,"ownerBlogUrl":30,"ownerDescription":31,"updatedAt":32,"install":33,"resources":46},"01M72S6SWSDXFB7KEC5TZY6NH0","resolve-pr-comments",null,"Triage and address CodeRabbit and reviewer comments on a quantum-vault PR. Filters out invalid suggestions that violate project conventions and enforces the full CI gate before re-pushing.","p-11\u002Fquantum-vault","p-11","https:\u002F\u002Favatars.githubusercontent.com\u002Fu\u002F187643446?v=4","01M72S62G38VYPMH9WSPQHE8MA","Project Eleven","01M72S62H61Y0MHGKSG7JTBZ1D",3,"MIT","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.claude\u002Fskills\u002Fresolve-pr-comments\u002FSKILL.md",[],[],"2026-11-10 22:39:42",false,"---\nname: resolve-pr-comments\ndescription: >-\n  Triage and address CodeRabbit and reviewer comments on a quantum-vault PR. Filters out\n  invalid suggestions that violate project conventions and enforces the full CI gate\n  before re-pushing.\nargument-hint: '[pr-number]'\n---\n\n# Resolve PR Comments\n\n## Workflow\n\n### 1. Fetch PR Comments\n\n```bash\n# Overview + conversation comments\ngh pr view \u003Cnumber> --comments\n\n# Inline code review comments (file-level)\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Fcomments\n\n# Full review verdicts\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Freviews\n```\n\nDetermine the repo `\u003Corg>` from `git remote -v`.\n\n### 2. Triage Each Comment\n\nRead every comment before making any changes. Categorize:\n\n| Category                      | Action                                                     |\n| ----------------------------- | ---------------------------------------------------------- |\n| Valid fix needed              | Code change required - address in step 3                   |\n| Already addressed             | Change is already present - reply confirming               |\n| Disagree (with reason)        | Conflicts with project conventions - reply in step 4       |\n| Not applicable \u002F outdated     | Reply briefly and dismiss                                  |\n\n### 3. Address Valid Comments\n\n1. Make the code change\n2. Run `pnpm l:c && pnpm p:c && pnpm test:unit` after each logical group of changes\n3. If errors appear, run `pnpm l:f` then fix any remaining issues manually\n4. Repeat until gates pass\n5. Reply to the comment explaining the fix:\n\n```bash\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Fcomments\u002F\u003Ccomment_id>\u002Freplies \\\n  -f body=\"Fixed - extracted the repeated calculation into \\`calculateAvgPrice\\` in \\`src\u002Flib\u002Fformat\u002Favg-price.ts\\`.\"\n```\n\n### 4. Respond to Invalid Comments\n\nReply clearly, respectfully, and cite the specific project convention when relevant:\n\n```bash\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Fcomments\u002F\u003Ccomment_id>\u002Freplies \\\n  -f body=\"Project convention is \\`type\\` over \\`interface\\` for data shapes (see CLAUDE.md). Keeping the current code.\"\n```\n\n### 5. CodeRabbit-Specific Handling\n\nCodeRabbit suggestions must be verified critically. Skip or reply-dismiss when it suggests any of the following:\n\n| CodeRabbit Suggestion                        | Why It Is Wrong Here                                                                   | Reply Template                                                                                                             |\n| -------------------------------------------- | -------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------- |\n| Use `interface` instead of `type`            | `type` for data shapes; `interface` only for class contracts                           | \"Convention is `type` over `interface` for data shapes.\"                                                                   |\n| Add `useMemo` \u002F `useCallback`                | React Compiler handles memoization                                                     | \"React Compiler handles memoization; manual `useMemo`\u002F`useCallback` is not used in this project.\"                          |\n| Add `?.` \u002F `??` on non-optional values       | Trust the type system; use `ensurePresent()` at boundaries only                        | \"The type guarantees this is present. Adding a fallback would mask a real bug.\"                                            |\n| Wrap in `try-catch` just to log              | `attempt()` for user-facing errors; otherwise let errors bubble                        | \"Convention uses `attempt()` for user-facing errors and lets internals bubble. No wrap needed here.\"                       |\n| Use `switch\u002Fcase`                            | Pattern matching only (Record lookups, `match()`, config arrays)                       | \"Convention is Record lookups \u002F `match()` instead of switch\u002Fcase.\"                                                         |\n| Replace arrow fns with `function` decls      | Arrow function expressions across the codebase                                         | \"Convention is arrow function expressions.\"                                                                                |\n| Hardcode hex \u002F add inline styles             | Theme tokens only (see `src\u002Findex.css`)                                                | \"Theme tokens are the source of truth for visuals; hardcoding colors is disallowed.\"                                       |\n| Instantiate `LibQC` outside `WalletProvider` | Single instance pattern preserved by `WalletProvider`                                  | \"`LibQC` is owned by `WalletProvider` as a `useRef` singleton; we do not instantiate it elsewhere.\"                        |\n\nFor any other CodeRabbit suggestion:\n\n1. Check if it aligns with `CLAUDE.md` and `.claude\u002Frules\u002F`\n2. Search the codebase for how similar code is written\n3. If it introduces a pattern not used in the project, skip it\n4. If it is a genuine improvement that aligns with conventions, apply it\n\n### 6. Commit, Push, Finalize\n\nAfter all comments are addressed:\n\n```bash\npnpm ci:pr\ngit add \u003Cspecific-files>\ngit commit -m \"$(cat \u003C\u003C'EOF'\nfix(scope): address PR review comments\n\n- Summary of the fixes that landed\nEOF\n)\"\ngit push\n```\n\nIf the PR still has pending reviewers, optionally re-request review:\n\n```bash\ngh pr edit \u003Cnumber> --add-reviewer \u003Creviewer-handle>\n```\n\n## Rules\n\n- Read every comment before making any changes - understand the full picture first\n- Batch related fixes into a single commit\n- Never dismiss valid feedback - if the comment reveals a real issue, fix it\n- Be respectful but firm when disagreeing; cite the specific convention\n- Never blindly apply CodeRabbit suggestions - verify each against project patterns\n- Run `pnpm ci:pr` before pushing - never push broken code\n- Do NOT include `Co-Authored-By` trailer\n","# Resolve PR Comments\n\n## Workflow\n\n### 1. Fetch PR Comments\n\n```bash\n# Overview + conversation comments\ngh pr view \u003Cnumber> --comments\n\n# Inline code review comments (file-level)\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Fcomments\n\n# Full review verdicts\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Freviews\n```\n\nDetermine the repo `\u003Corg>` from `git remote -v`.\n\n### 2. Triage Each Comment\n\nRead every comment before making any changes. Categorize:\n\n| Category                      | Action                                                     |\n| ----------------------------- | ---------------------------------------------------------- |\n| Valid fix needed              | Code change required - address in step 3                   |\n| Already addressed             | Change is already present - reply confirming               |\n| Disagree (with reason)        | Conflicts with project conventions - reply in step 4       |\n| Not applicable \u002F outdated     | Reply briefly and dismiss                                  |\n\n### 3. Address Valid Comments\n\n1. Make the code change\n2. Run `pnpm l:c && pnpm p:c && pnpm test:unit` after each logical group of changes\n3. If errors appear, run `pnpm l:f` then fix any remaining issues manually\n4. Repeat until gates pass\n5. Reply to the comment explaining the fix:\n\n```bash\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Fcomments\u002F\u003Ccomment_id>\u002Freplies \\\n  -f body=\"Fixed - extracted the repeated calculation into \\`calculateAvgPrice\\` in \\`src\u002Flib\u002Fformat\u002Favg-price.ts\\`.\"\n```\n\n### 4. Respond to Invalid Comments\n\nReply clearly, respectfully, and cite the specific project convention when relevant:\n\n```bash\ngh api repos\u002F\u003Corg>\u002Fquantum-vault\u002Fpulls\u002F\u003Cnumber>\u002Fcomments\u002F\u003Ccomment_id>\u002Freplies \\\n  -f body=\"Project convention is \\`type\\` over \\`interface\\` for data shapes (see CLAUDE.md). Keeping the current code.\"\n```\n\n### 5. CodeRabbit-Specific Handling\n\nCodeRabbit suggestions must be verified critically. Skip or reply-dismiss when it suggests any of the following:\n\n| CodeRabbit Suggestion                        | Why It Is Wrong Here                                                                   | Reply Template                                                                                                             |\n| -------------------------------------------- | -------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------- |\n| Use `interface` instead of `type`            | `type` for data shapes; `interface` only for class contracts                           | \"Convention is `type` over `interface` for data shapes.\"                                                                   |\n| Add `useMemo` \u002F `useCallback`                | React Compiler handles memoization                                                     | \"React Compiler handles memoization; manual `useMemo`\u002F`useCallback` is not used in this project.\"                          |\n| Add `?.` \u002F `??` on non-optional values       | Trust the type system; use `ensurePresent()` at boundaries only                        | \"The type guarantees this is present. Adding a fallback would mask a real bug.\"                                            |\n| Wrap in `try-catch` just to log              | `attempt()` for user-facing errors; otherwise let errors bubble                        | \"Convention uses `attempt()` for user-facing errors and lets internals bubble. No wrap needed here.\"                       |\n| Use `switch\u002Fcase`                            | Pattern matching only (Record lookups, `match()`, config arrays)                       | \"Convention is Record lookups \u002F `match()` instead of switch\u002Fcase.\"                                                         |\n| Replace arrow fns with `function` decls      | Arrow function expressions across the codebase                                         | \"Convention is arrow function expressions.\"                                                                                |\n| Hardcode hex \u002F add inline styles             | Theme tokens only (see `src\u002Findex.css`)                                                | \"Theme tokens are the source of truth for visuals; hardcoding colors is disallowed.\"                                       |\n| Instantiate `LibQC` outside `WalletProvider` | Single instance pattern preserved by `WalletProvider`                                  | \"`LibQC` is owned by `WalletProvider` as a `useRef` singleton; we do not instantiate it elsewhere.\"                        |\n\nFor any other CodeRabbit suggestion:\n\n1. Check if it aligns with `CLAUDE.md` and `.claude\u002Frules\u002F`\n2. Search the codebase for how similar code is written\n3. If it introduces a pattern not used in the project, skip it\n4. If it is a genuine improvement that aligns with conventions, apply it\n\n### 6. Commit, Push, Finalize\n\nAfter all comments are addressed:\n\n```bash\npnpm ci:pr\ngit add \u003Cspecific-files>\ngit commit -m \"$(cat \u003C\u003C'EOF'\nfix(scope): address PR review comments\n\n- Summary of the fixes that landed\nEOF\n)\"\ngit push\n```\n\nIf the PR still has pending reviewers, optionally re-request review:\n\n```bash\ngh pr edit \u003Cnumber> --add-reviewer \u003Creviewer-handle>\n```\n\n## Rules\n\n- Read every comment before making any changes - understand the full picture first\n- Batch related fixes into a single commit\n- Never dismiss valid feedback - if the comment reveals a real issue, fix it\n- Be respectful but firm when disagreeing; cite the specific convention\n- Never blindly apply CodeRabbit suggestions - verify each against project patterns\n- Run `pnpm ci:pr` before pushing - never push broken code\n- Do NOT include `Co-Authored-By` trailer\n",{"name":5,"description":7,"argument-hint":24},"[pr-number]","main","94843b628446f86d412a5c5661cf42a26c828b51",".claude\u002Fskills\u002Fresolve-pr-comments","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault","https:\u002F\u002Fgithub.com\u002Fp-11","https:\u002F\u002Fwww.projecteleven.com","Securing digital assets for the post-quantum era","2026-10-22 17:23:20",{"source":8,"skillName":5,"commands":34,"prompt":44,"zipAvailable":45},[35,38,41],{"tool":36,"command":37},"npx","npx skills add p-11\u002Fquantum-vault --skill resolve-pr-comments",{"tool":39,"command":40},"bunx","bunx skills add p-11\u002Fquantum-vault --skill resolve-pr-comments",{"tool":42,"command":43},"pnpm","pnpm dlx skills add p-11\u002Fquantum-vault --skill resolve-pr-comments","安装技能，技能地址：https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.claude\u002Fskills\u002Fresolve-pr-comments\u002FSKILL.md",true,[],[48,53,59,65,71,77],{"skillNo":49,"name":5,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":50,"categories":51,"keywords":52,"publishedAt":19},"01M72S75MAGAJ9BT5N5CM75TJ1","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.cursor\u002Fskills\u002Fresolve-pr-comments\u002FSKILL.md",[],[],{"skillNo":54,"name":55,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":56,"categories":57,"keywords":58,"publishedAt":19},"01M72S74P33WDYNZZVQB9PPSYQ","orchestrate","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.cursor\u002Fskills\u002Forchestrate\u002FSKILL.md",[],[],{"skillNo":60,"name":61,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":62,"categories":63,"keywords":64,"publishedAt":19},"01M72S73TEY2KR8F7ZKKWE1BTA","finish","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.cursor\u002Fskills\u002Ffinish\u002FSKILL.md",[],[],{"skillNo":66,"name":67,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":68,"categories":69,"keywords":70,"publishedAt":19},"01M72S72X56SDNX8TGRV3MHB5J","figma","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.cursor\u002Fskills\u002Ffigma\u002FSKILL.md",[],[],{"skillNo":72,"name":73,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":74,"categories":75,"keywords":76,"publishedAt":19},"01M72S7218NT062SK66MMZJYJD","delegate","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.cursor\u002Fskills\u002Fdelegate\u002FSKILL.md",[],[],{"skillNo":78,"name":79,"nameZh":6,"description":6,"descriptionZh":6,"repositoryFullName":8,"ownerLogin":9,"ownerAvatarUrl":10,"ownerAccountNo":11,"ownerDisplayName":12,"repositoryNo":13,"starsCount":14,"licenseSpdxId":15,"licenseFileUrl":6,"sourceHtmlUrl":80,"categories":81,"keywords":82,"publishedAt":19},"01M72S7144W92BM272E9CDAJM6","commit","https:\u002F\u002Fgithub.com\u002Fp-11\u002Fquantum-vault\u002Fblob\u002Fmain\u002F.cursor\u002Fskills\u002Fcommit\u002FSKILL.md",[],[]]