plan-review
Use only within active engineer/conduct DECIDE after coherence-check for Medium or Large work to adversarially review the final plan against the real source. Reports source-grounded findings; does not author or amend plan artifacts.
- License 许可
- Apache-2.0
- 最近更新
- 2026-11-11
- Stars
- ★ 7
- Forks
- 2
01 前言 Front Matter
- name
- plan-review
- phase
- decide
- description
- Use only within active engineer/conduct DECIDE after coherence-check for Medium or Large work to adversarially review the final plan against the real source. Reports source-grounded findings; does not author or amend plan artifacts.
- enforcement
- gating
- disable-model-invocation
- true
02 资源文件 1
- 参考文档agents/openai.yaml43 B
03 SKILL.md 正文
Purpose
Judge the final plan against the target worktree's real source after /coherence-check and before
land. This is an adversarial, source-grounded review: deterministic candidate rows are prompts for
judgment, never findings by themselves. Return only findings the supplied evidence supports; the
engine owns dispatch, schema validation, artifact rendering, operator dispositions, and land
enforcement.
Run only for Medium and Large work. For Small work, do not create a review artifact or substitute this review for the plan's §7b contradiction review.
Read-only review
This reviewer is read-only. It MUST NOT write or edit any worktree file, generated artifact, operator-decision store, configuration, or source; it MUST NOT stage or commit. Do not run tests, builds, formatters, or commands that modify project state. Inspect the supplied artifacts and source through the read-only session, then return the terminal structured result requested by the engine.
Inputs and evidence
Use the supplied stories, every plan task, relevant ADR Decision sections, coherence artifact,
candidate rows, and the target worktree source. ADR DECISIONS contains the decisions changed by
the spec. INDEX lists the remaining in-scope decisions and coherence artifact by path; read each
indexed item from its listed worktree path before relying on it. Assess the final plan rather than
reconstructing candidate generation or routing.
Every finding needs concrete evidence. Record a feasibility finding citing the source file:line
when a planned input differs from what production passes. Quote both passages for every
contradiction. An ungrounded suspicion is advisory at most: do not promote it to significant or
blocking merely because it sounds plausible.
Candidate lenses
Judge every supplied candidate under these lenses:
- test-impact: an existing test references a path or identifier a task changes, but no task updates that test.
- reachability: a planned export or primitive has no production caller in source and no task that supplies one.
- dependency-order: a task needs a path, export, or identifier that only a task outside its dependency closure introduces.
- feasibility: a planned step cannot work against the actual source, including when its planned input differs from the value production really passes.
Candidates with insufficient evidence are not findings. Search beyond candidates for the contradiction lenses below.
Contradiction sweep
Check static contradiction, oscillation, task-versus-task conflict, preserved-behavior conflict, and criterion-conflict. Treat ADR-versus-story as a cross-layer pair.
For every task-versus-task pair sharing a behavior, resource, state, input, output, or gate, ask: “if I fully satisfy A, does B still hold?” Then ask the other direction. Pairs with nothing shared need no finding. Two negative answers identify an oscillation; one may identify a static contradiction or another applicable conflict. A merely uncovered criterion is not a contradiction.
Layer ownership. Story↔story pairs belong to /conflict-check. Cross-layer and task versus task
pairs belong to plan review at Medium and Large tier, and to the plan's §7b at Small tier.
Verification
Before returning, verify the task-versus-task sweep considered both directions for every pair with a shared subject. Verify every reported finding has the required source-grounded evidence, and that each claimed contradiction quotes both opposing passages. Return no finding for a candidate or pair that the evidence does not support.
04 同仓库更多 Skills
build-review-dependency-hygiene
Judge whether a feature diff adds unnecessary, insufficiently pinned, or license-incompatible dependencies.
writing-system-tests
Use BEFORE implementing any feature that has stories in .docs/stories/ — generates failing acceptance specs from acceptance criteria as the RED phase of TDD. Generates HTTP/request-level acceptance tests for headless/API projects, end-to-end UI tests for projects with a frontend, using the project's own test framework and directory conventions.
verify-claims
Use only when an active workflow is about to rely on a nontrivial factual claim or assumption for a spec, plan, ADR, finding, or code decision. Do not invoke for casual questions, status reports, restatements, or trivially verifiable mechanics.
tdd
Use when implementing any feature or bugfix. Five-step cycle: RED → DOMAIN → GREEN → DOMAIN → COMMIT. Enforces test-first development with domain integrity review at every phase boundary.
stories
Use only within active engineer/conduct DECIDE after architecture approval, when a committed `.docs/stories` acceptance artifact is required. Do not invoke for general user-story examples, requirements discussion, or direct implementation requests.
stack-land
Use when an operator needs to land reviewed manual changes on the correct closed child of a stacked feature. Operator-invoked only: inspect ownership, propose the safe child with evidence, and require confirmation before opening the landing.