review/architecture
Architecture and design check — verify reason-to-change, policy-above-detail, interface truthfulness, registry normalization, source/artifact/installed boundary, surface separation, and degraded-path visibility.
- License 许可
- Apache-2.0
- 所属仓库
- usurobor/cnos
- 最近更新
- 2026-11-07
- Stars
- ★ 9
- Forks
- 0
01 前言 Front Matter
- name
- review/architecture
- calls
- []
- scope
- task-local
- inputs
- [ "branch", "diff", "diff/context findings from Phase 2b" ]
- parent
- review
- outputs
- [ "architecture check table (7 questions A–G with yes/no/n/a results)", "findings with severity and type" ]
- requires
- [ "Phase 1 (contract integrity) completed", "Phase 2b (diff/context inspection) completed", "review orchestrator loaded" ]
- triggers
- [ "review architecture", "review design" ]
- visibility
- internal
- description
- Architecture and design check — verify reason-to-change, policy-above-detail, interface truthfulness, registry normalization, source/artifact/installed boundary, surface separation, and degraded-path visibility.
- kata_surface
- external
- artifact_class
- skill
- governing_question
- How does β verify that the branch preserves architectural boundaries and does not smear runtime surfaces, violate policy placement, or hide degraded paths?
02 资源文件 8
- 参考文档references/resource_semantics.md10.9 KB
- 参考文档references/snapshot_schema.md6.4 KB
- 参考文档references/sources.md8.2 KB
- 脚本scripts/_common.py6.4 KB
- 脚本scripts/accelerator_diagnostics.py4.5 KB
- 脚本scripts/detect_resources.py64.6 KB
- 脚本scripts/plan_workload.py10.9 KB
- 脚本scripts/snapshot_tools.py17.6 KB
03 SKILL.md 正文
Review — Phase 2c: Architecture and Design Check
PRE-GATE: Phase 2b (diff/context inspection) must be completed.
Activate when the change touches: package boundaries, command/provider/orchestrator/skill separation, source/artifact/installed flow, registry design, kernel vs package responsibility, transport vs protocol semantics, command dispatch vs domain logic.
Load: src/packages/cnos.core/skills/design/SKILL.md when active.
§2.2 Architecture and design check
| Check | Question |
|---|---|
| A. Reason to change | Does each touched module still have one real reason to change? |
| B. Policy above detail | Does policy remain in the kernel/core? |
| C. Truthful interface | Does each interface promise only what all implementations support? |
| D. Registry normalization | Do different source forms normalize into one runtime descriptor? |
| E. Source/artifact/installed | Is it still clear what is authored, built, and installed? |
| F. Surface separation | Are skills, commands, orchestrators, providers distinct? |
| G. Degraded-path visibility | Is fallback behavior visible and testable? |
Output block (include when active):
## Architecture Check
| Check | Result | Notes |
|---|---|---|
| Reason to change preserved | yes / no / n/a | |
| Policy above detail preserved | yes / no / n/a | |
| Interfaces remain truthful | yes / no / n/a | |
| Registry model remains unified | yes / no / n/a | |
| Source/artifact/installed boundary preserved | yes / no / n/a | |
| Runtime surfaces remain distinct | yes / no / n/a | |
| Degraded paths visible and testable | yes / no / n/a | |
If any Architecture Check row is "no," the review cannot approve without an explicit issue-backed redesign or scope reduction.
Rules:
- Silent architectural boundary smear is a blocking finding.
- Silent source-of-truth duplication is a blocking finding.
- Intentional constraint revision must be named explicitly.
After Phase 2c
Collect architecture findings. Return to orchestrator (review/SKILL.md) for verdict rules and output format.
04 同仓库更多 Skills
issues/triage
Issue triage doctrine pointer. Use when classifying a new issue, deciding dispatch eligibility, or deciding whether to close/supersede/defer.
issues/taxonomy
Issue label taxonomy pointer. Use when classifying an issue's kind/area/priority/effort/status/protocol/dispatch labels, or when the board needs to interpret them.
issues/map
Issue-board (Issue Pivot) generation domain. Use when reasoning about `cn issues map`'s fetch, taxonomy-parse, effort-computation, and render pipeline, or about the board's JSON/HTML output contract.
issues
cnos.issues package entrypoint. Use when reasoning about issue taxonomy, the Issue Pivot / issue-board (`cn issues map`), the read-only CDS issue-state evaluator (`cn issues fsm evaluate`), or the current command-dispatch disposition of issue tooling.
receipt-stream
Cross-cycle receipt-stream doctrine for protocol-iteration. Use when γ closes a cycle and writes the per-cycle iteration artifact (`cdd-iteration.md`), when γ updates the cross-cycle aggregator at `.cdd/iterations/INDEX.md`, when ε reads the receipt stream across cycles to surface protocol-gap patterns, when a finding's disposition lands a cross-repo patch and the cross-repo trace bundle attaches, or when a courtesy empty-findings stub is written for a `protocol_gap_count == 0` cycle.
mid-flight
Mid-flight γ→in-flight-α rescue channel. Use when γ needs to change a load-bearing fact (pinned axis, scope, AC, blocker) after α has begun coding, when γ edits the cycle's GitHub issue body mid-cycle, or when a spec change lands on origin/main while α/β polling sessions are in-flight.